Skip to content

bpo-31158: Fix test_pty.test_basic() #3802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vstinner wants to merge 2 commits into from
Closed

bpo-31158: Fix test_pty.test_basic() #3802

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cef1e36
bpo-31158: Fix test_pty.test_basic()
vstinner Sep 28, 2017
3e6a106
reuse TEST_STRING_2 constant
vstinner Sep 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
bpo-31158: Fix test_pty.test_basic() 
Sometimes, the first read only returns the first written 5 bytes and
a second read is need to get the second part.
  • Loading branch information
@vstinner
vstinner committed Sep 28, 2017
commit cef1e369454845b14c65a1712b65a4708cf62c1a
11 changes: 10 additions & 1 deletion Lib/test/test_pty.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,17 @@ def test_basic(self):
debug("Writing chunked output")
os.write(slave_fd, TEST_STRING_2[:5])
os.write(slave_fd, TEST_STRING_2[5:])

expected = b'For my pet fish, Eric.\n'
s2 = os.read(master_fd, 1024)
self.assertEqual(b'For my pet fish, Eric.\n', normalize_output(s2))
# bpo-31158: Sometimes, the first read only returns the first
# written 5 bytes and a second read is need to get the second part.
while len(s2) < len(expected):
chunk = os.read(master_fd, 1024)
if not chunk:
break
s2 += chunk
self.assertEqual(expected, normalize_output(s2))

os.close(slave_fd)
os.close(master_fd)
Expand Down