Skip to content

bpo-30780: Add IDLE configdialog tests #3592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terryjreedy merged 11 commits into from
Jan 27, 2020
Merged

bpo-30780: Add IDLE configdialog tests #3592

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ef4584c
bpo-30780: IDLE: Complete keys and highlight coverage for configdialo…
csabella Sep 14, 2017
648b850
Correct tests due to other changes
csabella Jan 19, 2020
bcea0fb
Merge branch 'master' into bpo30780
terryjreedy Jan 25, 2020
45e60ff
Fix test failure - cannot use patch for instance addition and deletion.
terryjreedy Jan 25, 2020
5a8e94f
Use mock.patch.object as context manager.
terryjreedy Jan 25, 2020
14e9efc
Test selection block bindings.
terryjreedy Jan 26, 2020
0b234eb
Eliminate reason to test with duplicate new names.
terryjreedy Jan 26, 2020
168d07e
Complete last commit, which changed highlight code
terryjreedy Jan 26, 2020
18499bf
News items.
terryjreedy Jan 27, 2020
60982c4
Update NEWS.txt
terryjreedy Jan 27, 2020
c7d7ce2
Update 2020-01-27-16-44-29.bpo-30780.nR80qu.rst
terryjreedy Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Eliminate reason to test with duplicate new names.
  • Loading branch information
@terryjreedy
terryjreedy committed Jan 26, 2020
commit 0b234eb6ca9895523a48787b4ecfa3d2bd7c54a3
3 changes: 1 addition & 2 deletions Lib/idlelib/configdialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1286,8 +1286,7 @@ def save_new(self, theme_name, theme):
theme_name - string, the name of the new theme
theme - dictionary containing the new theme
"""
if not idleConf.userCfg['highlight'].has_section(theme_name):
idleConf.userCfg['highlight'].add_section(theme_name)
idleConf.userCfg['highlight'].AddSection(theme_name)
for element in theme:
value = theme[element]
idleConf.userCfg['highlight'].SetOption(theme_name, element, value)
Expand Down
11 changes: 0 additions & 11 deletions Lib/idlelib/idle_test/test_configdialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1100,17 +1100,6 @@ def test_create_new_key_set_and_save_new_key_set(self):
self.assertFalse(d.keyset_source.get()) # Use custom set.
eq(d.set_keys_type.called, 1)

# Call with same name as first time to make sure it adds it only once.
d.keyset_source.set(True)
d.builtin_name.set('IDLE Classic Windows')
d.create_new_key_set(first_new)
eq(idleConf.GetSectionList('user', 'keys'), [first_new])
eq(idleConf.GetKeySet('IDLE Classic Windows'),
idleConf.GetKeySet(first_new))
eq(d.custom_name.get(), first_new)
self.assertFalse(d.keyset_source.get()) # Use custom set.
eq(d.set_keys_type.called, 2)

# Test that changed keybindings are in new keyset.
changes.add_option('keys', first_new, 'copy', '<Key-F11>')
self.assertNotIn(second_new, idleConf.userCfg)
Expand Down