Skip to content

bpo-47215: Add undocumented, unstable FrameStack API for use by greenlets and similar libraries. #32303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markshannon wants to merge 5 commits into from
Closed

bpo-47215: Add undocumented, unstable FrameStack API for use by greenlets and similar libraries. #32303

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5422b53
Add undocumented, unstable FrameStack API for use by greenlets and si…
markshannon Apr 4, 2022
f6a46a6
Add minimal documentation.
markshannon Apr 4, 2022
ca6b767
Merge branch 'main' into frame-stack-api
markshannon Aug 17, 2022
b21d198
Merge branch 'main' into frame-stack-api
markshannon Sep 7, 2022
1a82683
Change top/limit pair to free/limit pair to allow fast checks and NUL…
markshannon Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add minimal documentation.
  • Loading branch information
@markshannon
markshannon committed Apr 4, 2022
commit f6a46a634ff0aad024c7a4386fe7338b53d31eaa
8 changes: 8 additions & 0 deletions Include/cpython/pystate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,15 @@ typedef int (*crossinterpdatafunc)(PyObject *, _PyCrossInterpreterData *);
PyAPI_FUNC(int) _PyCrossInterpreterData_RegisterClass(PyTypeObject *, crossinterpdatafunc);
PyAPI_FUNC(crossinterpdatafunc) _PyCrossInterpreterData_Lookup(PyObject *);

/* UNSTABLE API for stackful coroutines.

@jdahlin jdahlin Apr 4, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about hiding this behind an ifdef, it would technically be an api break, but would make the intention clearer:

#ifdef _PYTHON_C_UNSTABLE_FRAMESTACK_API
...
#endif

* It it the responsibility of the caller to manage the memory for the _PyFrameStack struct.
* The memory for the actual frame stack will be managed by the VM.
* All functions need the GIL to be held.
*/

/* Initialize fs with given chunk size */
PyAPI_FUNC(void) _PyFrameStack_Init(_PyFrameStack *fs, int chunk_size);
/* Swap the frame stack of the current thread with fs */
PyAPI_FUNC(void) _PyFrameStack_Swap(_PyFrameStack *fs);
/* Free any allocated memory chunks from fs. Does not free fs itself */
PyAPI_FUNC(void) _PyFrameStack_Free(_PyFrameStack *fs);