Skip to content

bpo-43224: Add TypeVarTuple.__name__ #31954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 2 commits into from
Mar 18, 2022
Merged

bpo-43224: Add TypeVarTuple.__name__ #31954

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aac15f8
bpo-43224: Add TypeVarTuple.__name__
JelleZijlstra Mar 17, 2022
da0ca6d
remove duplicate test
JelleZijlstra Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
bpo-43224: Add TypeVarTuple.__name__ 
I noticed that TypeVar and ParamSpec put their name in a __name__
attribute, but TypeVarTuple doesn't. Let's be consistent.
  • Loading branch information
@JelleZijlstra
JelleZijlstra committed Mar 17, 2022
commit aac15f80c2ad5359986a372aa41a648ee60bc413
6 changes: 6 additions & 0 deletions Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,12 @@ def assertEndsWith(self, string, tail):
if not string.endswith(tail):
self.fail(f"String {string!r} does not end with {tail!r}")

def test_name(self):
Ts = TypeVarTuple('Ts')
self.assertEqual(Ts.__name__, 'Ts')
Ts2 = TypeVarTuple('Ts2')
self.assertEqual(Ts2.__name__, 'Ts2')

def test_instance_is_equal_to_itself(self):
Ts = TypeVarTuple('Ts')
self.assertEqual(Ts, Ts)
Expand Down
4 changes: 2 additions & 2 deletions Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,13 +939,13 @@ class C(Generic[*Ts]): ...
"""

def __init__(self, name):
self._name = name
self.__name__ = name

def __iter__(self):
yield Unpack[self]

def __repr__(self):
return self._name
return self.__name__

def __typing_subst__(self, arg):
raise AssertionError
Expand Down