Skip to content

bpo-40255: Implement Immortal Instances - Optimization 3 #31490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eduardo-elizondo wants to merge 4 commits into from
Closed

bpo-40255: Implement Immortal Instances - Optimization 3 #31490

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
420967a
bpo-40255: Implement Immortal Instances - Optimization 3
eduardo-elizondo Feb 20, 2022
e756b30
Immortalize module as well
eduardo-elizondo Feb 21, 2022
5d806ae
Only immortalize top level modules
eduardo-elizondo Feb 22, 2022
e153dc5
Fix tests
eduardo-elizondo Feb 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix tests
  • Loading branch information
@eduardo-elizondo
eduardo-elizondo committed Feb 22, 2022
commit e153dc541e0b640df6fa0f714743b5e3c9da3c13
1 change: 1 addition & 0 deletions Lib/test/test_gc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,6 +723,7 @@ def __del__(self):
rc, out, err = assert_python_ok('-c', code)
self.assertEqual(out.strip(), b'__del__ called')

@unittest.skipIf(True, 'Fixed in Optimization 2 with topological destruction')
def test_gc_ordinary_module_at_shutdown(self):
# Same as above, but with a non-__main__ module.
with temp_dir() as script_dir:
Expand Down
1 change: 1 addition & 0 deletions Lib/test/test_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,7 @@ def test_module_repr_source(self):
self.assertEqual(r[-len(ends_with):], ends_with,
'{!r} does not end with {!r}'.format(r, ends_with))

@unittest.skipIf(True, 'Fixed in Optimization 2 with topological destruction')
def test_module_finalization_at_shutdown(self):
# Module globals and builtins should still be available during shutdown
rc, out, err = assert_python_ok("-c", "from test import final_a")
Expand Down