Skip to content

bpo-46823: Implement LOAD_FAST__LOAD_ATTR_INSTANCE_VALUE #31484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 8 commits into from
Feb 24, 2022
Merged

bpo-46823: Implement LOAD_FAST__LOAD_ATTR_INSTANCE_VALUE #31484

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1e2ce9c
Implement LOAD_FAST__LOAD_ATTR_INSTANCE_VALUE
sweeneyde Feb 22, 2022
dd3e143
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 22, 2022
b6e0b7b
Fix compilation for Py_STATS
sweeneyde Feb 22, 2022
9f0b4a4
merge with main
sweeneyde Feb 22, 2022
ec5b712
Improve comment
sweeneyde Feb 22, 2022
273926c
From review: do LOAD_FAST and jump to a shared miss label
sweeneyde Feb 24, 2022
5da9b2a
Catch up with main: no _PyAttrCache needed
sweeneyde Feb 24, 2022
6450e4b
Update comment
sweeneyde Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update comment
  • Loading branch information
@sweeneyde
sweeneyde committed Feb 24, 2022
commit 6450e4bc64b0cc41e48c3f0ee61c011f7e484846
2 changes: 1 addition & 1 deletion Python/ceval.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3457,7 +3457,7 @@ _PyEval_EvalFrameDefault(PyThreadState *tstate, InterpreterFrame *frame, int thr
_PyAdaptiveEntry *cache0 = &caches[0].adaptive;
assert(cache0->version != 0);
PyTypeObject *tp = Py_TYPE(owner);
// Note: these DEOPT_IFs jump back to LOAD_FAST.
// These DEOPT_IF miss branches do PUSH(Py_NewRef(owner)).
DEOPT_IF(tp->tp_version_tag != cache0->version,
LOAD_FAST__LOAD_ATTR_INSTANCE_VALUE);
assert(tp->tp_dictoffset < 0);
Expand Down