Skip to content

gh-64978: Add chown() to pathlib.Path #31212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
y0urself wants to merge 7 commits into from
Closed

gh-64978: Add chown() to pathlib.Path #31212

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8906802
bpo-20779 add chown() and lchown() to Path() in pathlib
y0urself Feb 8, 2022
5bb6b63
Add tests for chown() and lchown() for pathlib.Path()
y0urself Feb 8, 2022
dbdbbbe
Add patch entry to Misc/NEWS.d/next
y0urself Feb 8, 2022
d4070a3
Add documentation for chown and lchown, fix typo in lchmod
y0urself Feb 8, 2022
f9a611b
Improve and extend the tests
y0urself Feb 8, 2022
06aebeb
Remove `lchown()`, don't expose `dir_fd`
y0urself May 3, 2022
cfae2d4
Apply suggestions from code review
y0urself May 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
bpo-20779 add chown() and lchown() to Path() in pathlib 
No support for WindowsPath
  • Loading branch information
@y0urself
y0urself committed Feb 13, 2022
commit 89068025e43da426ec1c715d0a0d346df53e1192
19 changes: 19 additions & 0 deletions Lib/pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1127,6 +1127,19 @@ def lchmod(self, mode):
"""
self.chmod(mode, follow_symlinks=False)

def chown(self, uid, gid, *, dir_fd=None, follow_symlinks=True):
"""
Change the owner and group id of path to the numeric uid and gid, like os.chown().
"""
Comment on lines +1131 to +1133

@brettcannon brettcannon May 12, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow PEP 8.

Suggested change
"""
Change the owner and group id of path to the numeric uid and gid, like os.chown().
"""
"""Change the owner and group id of path to the numeric uid and gid, like os.chown()."""

os.chown(self, uid, gid, dir_fd=dir_fd, follow_symlinks=follow_symlinks)

def lchown(self, uid, gid, *, dir_fd=None):
"""
Like chown(), except if the path points to a symlink, the symlink's
permissions are changed, rather than its target's.
"""
self.chown(uid, gid, dir_fd=dir_fd, follow_symlinks=False)

def unlink(self, missing_ok=False):
"""
Remove this file or link.
Expand Down Expand Up @@ -1393,3 +1406,9 @@ class WindowsPath(Path, PureWindowsPath):

def is_mount(self):
raise NotImplementedError("Path.is_mount() is unsupported on this system")

def chown(self, uid, gid, *, dir_fd=None, follow_symlinks=True):
raise NotImplementedError("Path.chown() is unsupported on this system")

def lchown(self, uid, gid, *, dir_fd=None):
raise NotImplementedError("Path.lchown() is unsupported on this system")