Skip to content

bpo-46679: Don't ignore timeout argument in test.support.wait_process. #31205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
notarealdeveloper wants to merge 3 commits into from
Closed

bpo-46679: Don't ignore timeout argument in test.support.wait_process. #31205

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12a5562
Fix bug in timeout kwd of test.support.wait_process
notarealdeveloper Feb 1, 2022
fedb85f
Add NEWS.d entry.
notarealdeveloper Feb 7, 2022
40dc1cc
Remove NEWS.d entry.
notarealdeveloper May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add NEWS.d entry.
  • Loading branch information
@notarealdeveloper
notarealdeveloper committed Feb 7, 2022
commit fedb85fc853d4007c33fab5fa3f001c864bd328b
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Tests/2022-02-07-13-24-28.bpo-46679.S-HI_R.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
The function ``wait_process`` in ``Lib/test/support/__init__.py`` no longer

@sobolevn sobolevn Feb 11, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEWS are not required for test-only changes. We need them for user-facing changes only 🙂

@notarealdeveloper notarealdeveloper Feb 14, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know! Thanks! :)

ignores its ``timeout`` argument.