Skip to content

bpo-46066: Deprecate kwargs syntax for TypedDict definitions #31126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 11 commits into from
Feb 17, 2022
Merged

bpo-46066: Deprecate kwargs syntax for TypedDict definitions #31126

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0c12774
Remove kwargs syntax for TypedDict
97littleleaf11 Feb 4, 2022
f3588ac
Add deprecation flag and warning
97littleleaf11 Feb 7, 2022
4d988a8
Add blurb and address reviews
97littleleaf11 Feb 8, 2022
f21c30a
Change docs
97littleleaf11 Feb 8, 2022
3f60fb0
Add name
97littleleaf11 Feb 8, 2022
033cf07
Fix
97littleleaf11 Feb 8, 2022
eea168f
Modify docs
97littleleaf11 Feb 9, 2022
15a7930
Use bullet list
97littleleaf11 Feb 13, 2022
b9badea
Fix
97littleleaf11 Feb 13, 2022
a6a870c
Fix
97littleleaf11 Feb 13, 2022
8b113dd
reverse
97littleleaf11 Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add name
  • Loading branch information
@97littleleaf11
97littleleaf11 committed Feb 8, 2022
commit 3f60fb0bed883eaf7ea011ebb63982ff450fcb07
1 change: 1 addition & 0 deletions Misc/ACKS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1976,6 +1976,7 @@ Masayuki Yamamoto
Ka-Ping Yee
Chi Hsuan Yen
Jason Yeo
Jingchen Ye

@AlexWaygood AlexWaygood Feb 8, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels absurd to bring this up (sorry!!), but: I think "Jingchen Ye" should go before "Ka-Ping Yee", if we're keeping this list alphabetised.

EungJun Yi
Bob Yodlowski
Danny Yoo
Expand Down
3 changes: 2 additions & 1 deletion Misc/NEWS.d/next/Library/2022-02-08-16-42-20.bpo-46066.m32Hl0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Remove kwargs-based syntax for TypedDict definition
Deprecate kwargs-based syntax for :class:`typing.TypedDict` definitions.
It was unsupported by type checkers. Patch by Jingchen Ye.

@JelleZijlstra JelleZijlstra Feb 8, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It was unsupported by type checkers. Patch by Jingchen Ye.
Patch by Jingchen Ye.

Pyright supports it.

@AlexWaygood AlexWaygood Feb 9, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to give a short summary of why this change is being made. Maybe It had confusing semantics, and was largely unused.?