Skip to content

bpo-46581: Propagate private vars via _GenericAlias.copy_with #31061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 9 commits into from
Mar 10, 2022
Merged

bpo-46581: Propagate private vars via _GenericAlias.copy_with #31061

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
90bdf0d
bpo-46581: Propagate private vars via _GenericAlias.copy_with
posita Feb 1, 2022
19e9207
Move tests to test_typing
posita Feb 26, 2022
e30f7ea
Move copy edits to #31684
posita Mar 4, 2022
06bd0c3
Update Lib/typing.py
posita Mar 6, 2022
2cd8199
Adopt @serhiy-storchaka's suggestions for approach
posita Mar 8, 2022
b222b3d
Remove redunant in-test imports
posita Mar 9, 2022
ad0431d
Recraft test to not depend on internal details
posita Mar 9, 2022
6db57f5
Move test to ParamSpecTests
posita Mar 10, 2022
031c617
Update Lib/test/test_typing.py
serhiy-storchaka Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Recraft test to not depend on internal details
  • Loading branch information
@posita
posita committed Mar 9, 2022
commit ad0431d2ee8d06d0304a83276fa25117cdd04760
5 changes: 3 additions & 2 deletions Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2802,11 +2802,12 @@ def __init__(self, attr: T) -> None:
self.assertEqual(deepcopy(ci).attr, 1)
self.assertEqual(ci.__orig_class__, C[int])

def test_copy_with(self):
def test_parameter_propagation(self):
# bpo-46581
P = ParamSpec('P')
original = Callable[P, int]
copied = original.copy_with((P, int))
self.assertEqual(original.__parameters__, (P,))
copied = original[P]
self.assertEqual(original.__parameters__, copied.__parameters__)

def test_weakref_all(self):
Expand Down