Skip to content

bpo-46406: Faster single digit int division. #30626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdickinson merged 4 commits into from
Jan 23, 2022
Merged

bpo-46406: Faster single digit int division. #30626

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
660cc78
bpo-46406: Faster single digit int division.
gpshead Jan 16, 2022
91b1050
re-add the assert, reword news.
gpshead Jan 17, 2022
d09f0c7
Spell Mark's name properly.
gpshead Jan 22, 2022
9902dc2
Add a cast to silence a compiler warning.
gpshead Jan 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Spell Mark's name properly. 
Co-authored-by: Mark Dickinson <dickinsm@gmail.com>
  • Loading branch information
@gpshead @mdickinson
gpshead and mdickinson authored Jan 22, 2022
commit d09f0c73fb863dd2dfc9d815568fac54a2afa57a
2 changes: 1 addition & 1 deletion Objects/longobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1620,7 +1620,7 @@ v_rshift(digit *z, digit *a, Py_ssize_t m, int d)

This version of the code can be 20% faster than the pre-2022 version
on todays compilers on architectures like amd64. It evolved from Mark
Dickenson observing that a 128:64 divide instruction was always being
Dickinson observing that a 128:64 divide instruction was always being
generated by the compiler despite us working with 30-bit digit values.
See the thread for full context:

Expand Down