Skip to content

bpo-46244: Remove __slots__ from typing.TypeVar, .ParamSpec #30444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 5 commits into from
Jan 10, 2022
Merged

bpo-46244: Remove __slots__ from typing.TypeVar, .ParamSpec #30444

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f3362f4
add missing __slots__ to typing._TypeVarLike
ariebovenberg Jan 6, 2022
4cd5d2e
add news entry
ariebovenberg Jan 6, 2022
2c9f75e
remove slots from _TypeVarLike base classes
ariebovenberg Jan 10, 2022
e6f9966
cleanup diff
ariebovenberg Jan 10, 2022
34ec10c
fix broken link in blurb
ariebovenberg Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,9 +805,6 @@ def longest(x: A, y: A) -> A:
Note that only type variables defined in global scope can be pickled.
"""

__slots__ = ('__name__', '__bound__', '__constraints__',
'__covariant__', '__contravariant__', '__dict__')

def __init__(self, name, *constraints, bound=None,
covariant=False, contravariant=False):
self.__name__ = name
Expand Down Expand Up @@ -907,9 +904,6 @@ def add_two(x: float, y: float) -> float:
be pickled.
"""

__slots__ = ('__name__', '__bound__', '__covariant__', '__contravariant__',
'__dict__')

@property
def args(self):
return ParamSpecArgs(self)
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2022-01-06-21-31-14.bpo-46244.hjyfJj.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Removed ``__slots__`` from :class:``typing.ParamSpec`` and :class:``typing.TypeVar``.

@kumaraditya303 kumaraditya303 Jan 10, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Removed ``__slots__`` from :class:``typing.ParamSpec`` and :class:``typing.TypeVar``.
Removed ``__slots__`` from :class:`typing.ParamSpec` and :class:`typing.TypeVar`.

rst uses single backticks.

@ariebovenberg ariebovenberg Jan 10, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops! Committed the fix below ✅

They served no purpose. Patch by Arie Bovenberg.