Skip to content

[WIP] bpo-31160: test PR used to bisect reap_children() warnings #3040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vstinner wants to merge 10 commits into from
Closed

[WIP] bpo-31160: test PR used to bisect reap_children() warnings #3040

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9f155dd
Enhance support.reap_children()
vstinner Aug 9, 2017
8b1aec0
[WIP] bisect on failure
vstinner Aug 9, 2017
68014b5
only run test_thread test_unittest test_socketserver test_select tes…
vstinner Aug 9, 2017
11a8355
Revert "only run test_thread test_unittest test_socketserver test_se…
vstinner Aug 9, 2017
223b8b7
Optimize support._match_test()
vstinner Aug 9, 2017
d2fe439
test_regrtest: disable broken test_env_changed()
vstinner Aug 9, 2017
1920581
test_regrtest: skip more broken tests
vstinner Aug 9, 2017
b95f435
reap_children: wait 1 second
vstinner Aug 9, 2017
27b8f51
Disable reap_children()
vstinner Aug 10, 2017
9e45a7f
Add socketserver.ForkingMixIn.server_close()
vstinner Aug 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[WIP] bisect on failure
  • Loading branch information
@vstinner
vstinner committed Aug 10, 2017
commit 8b1aec0aabc5a8c424e037bc6ba7e40b8b6ad1b6
44 changes: 35 additions & 9 deletions Lib/test/libregrtest/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,27 @@ def format_duration(seconds):
return '%.0f min %.0f sec' % (minutes, seconds)


def run_bisect_in_subprocess(testname):
from subprocess import Popen, PIPE
import json

cmd = [sys.executable, *support.args_from_interpreter_flags(),
'-u', # Unbuffered stdout and stderr
'-m', 'test.bisect',
'--fail-env-changed',
testname]

# Running the child from the same working directory as regrtest's original
# invocation ensures that TEMPDIR for the child is the same when
# sysconfig.is_python_build() is true. See issue 15300.
popen = Popen(cmd,
close_fds=(os.name != 'nt'),
cwd=support.SAVEDCWD)
with popen:
retcode = popen.wait()
return retcode


class Regrtest:
"""Execute a test suite.

Expand Down Expand Up @@ -276,26 +297,27 @@ def list_cases(self):
print(count(len(self.skipped), "test"), "skipped:", file=sys.stderr)
printlist(self.skipped, file=sys.stderr)

def rerun_failed_tests(self):
def rerun_failed_tests(self, tests):
self.ns.verbose = True
self.ns.failfast = False
self.ns.verbose3 = False
self.ns.match_tests = None

print("Re-running failed tests in verbose mode")
for test in self.bad[:]:
print("Re-running test %r in verbose mode" % test, flush=True)
print("Run bisection on failed tests")
for test in tests:
print("Bisect test %r" % test, flush=True)
try:
self.ns.verbose = True
ok = runtest(self.ns, test)
retcode = run_bisect_in_subprocess(test)
except KeyboardInterrupt:
self.interrupted = True
# print a newline separate from the ^C
print()
break
else:
if ok[0] in {PASSED, ENV_CHANGED, SKIPPED, RESOURCE_DENIED}:
self.bad.remove(test)
pass
#if ok[0] in {PASSED, ENV_CHANGED, SKIPPED, RESOURCE_DENIED}:
# self.bad.remove(test)
else:
if self.bad:
print(count(len(self.bad), 'test'), "failed again:")
Expand Down Expand Up @@ -538,8 +560,12 @@ def _main(self, tests, kwargs):
self.run_tests()
self.display_result()

if self.ns.verbose2 and self.bad:
self.rerun_failed_tests()
tests = self.bad
for test in self.environment_changed:
if test not in tests:
tests.append(test)
if self.ns.verbose2 and tests:
self.rerun_failed_tests(tests)

self.finalize()
if self.bad:
Expand Down