Skip to content

bpo-43224: Draft implementation of PEP 646 #30398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrahtz wants to merge 18 commits into from
Closed

bpo-43224: Draft implementation of PEP 646 #30398

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
64abc0a
PEP 646: Grammar and compiler changes
mrahtz Dec 3, 2021
b725671
PEP 646: Add tests for syntax changes
mrahtz Jan 3, 2022
ea329b9
PEP 646: Add AST tests for *args annotations
mrahtz Dec 7, 2021
681dc4e
PEP 646: Add AST tests for return types with unpacking
mrahtz Dec 7, 2021
69f575f
PEP 646: Add AST tests for variable annotations with unpacking
mrahtz Dec 7, 2021
095a620
PEP 646: Add support for starring tuple types
mrahtz Jan 2, 2022
6713748
PEP 646: Add tests for starring tuple types
mrahtz Jan 2, 2022
038b8f0
PEP 646: Implement support in typing.py
mrahtz Jan 2, 2022
f028339
PEP 646: Add tests for everything in typing.py
mrahtz Jan 2, 2022
38c17d3
PEP 646: Add tests for typing.get_{origin,args}
mrahtz Jan 4, 2022
9991937
PEP 646: Various fixes to genericaliasobject.c
mrahtz Jan 15, 2022
9017d22
PEP 646: Fix test_pep646_syntax import
mrahtz Jan 15, 2022
07ed599
PEP 646: Add docstring for TypeVarTuple
mrahtz Jan 17, 2022
74e5252
PEP 646: Swap a Py_INCREF with a Py_NewRef
mrahtz Jan 20, 2022
6cb3aa5
PEP 646: Add test for assigning to a slice containing a star
mrahtz Jan 20, 2022
daef59b
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 20, 2022
3c2a7e7
PEP 646: Add line to Doc/whatsnew
mrahtz Jan 20, 2022
456156a
PEP 646: Use stdbool.h; separate test cases
mrahtz Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
PEP 646: Use stdbool.h; separate test cases
  • Loading branch information
@mrahtz
mrahtz committed Jan 25, 2022
commit 456156a3106fa2d05c0ce155313697af9668bd66
7 changes: 4 additions & 3 deletions Lib/test/test_genericalias.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
from queue import Queue, SimpleQueue
from weakref import WeakSet, ReferenceType, ref
import typing
from typing import Callable, Dict, List

from typing import TypeVar, TypeVarTuple
T = TypeVar('T')
Expand Down Expand Up @@ -178,9 +179,7 @@ def test_exposed_type(self):
self.assertEqual(a.__args__, (int,))
self.assertEqual(a.__parameters__, ())

def test_parameters(self):
from typing import List, Dict, Callable

def test_dict_parameters(self):
D0 = dict[str, int]
self.assertEqual(D0.__args__, (str, int))
self.assertEqual(D0.__parameters__, ())
Expand All @@ -197,6 +196,7 @@ def test_parameters(self):
self.assertEqual(D2b.__args__, (T, T))
self.assertEqual(D2b.__parameters__, (T,))

Comment thread
mrahtz marked this conversation as resolved.
def test_list_parameters(self):
L0 = list[str]
self.assertEqual(L0.__args__, (str,))
self.assertEqual(L0.__parameters__, ())
Expand All @@ -219,6 +219,7 @@ def test_parameters(self):
self.assertEqual(L5.__args__, (Callable[[K, V], K],))
self.assertEqual(L5.__parameters__, (K, V))

def test_tuple_parameters(self):
with self.assertRaises(TypeError):
tuple[*list[int]]

Expand Down
6 changes: 4 additions & 2 deletions Objects/genericaliasobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
#include "pycore_unionobject.h" // _Py_union_type_or, _PyGenericAlias_Check
#include "structmember.h" // PyMemberDef

#include <stdbool.h>

typedef struct {
PyObject_HEAD
PyObject *origin;
Expand All @@ -13,7 +15,7 @@ typedef struct {
PyObject* weakreflist;
// Whether we're a starred type, e.g. *tuple[int].
// Only supported for `tuple`.
int starred;
bool starred;
} gaobject;

typedef struct {
Expand Down Expand Up @@ -646,7 +648,7 @@ ga_iternext(gaiterobject *gi) {
}
gaobject *alias = (gaobject *) gi->obj;
PyObject *starred_tuple = Py_GenericAlias(alias->origin, alias->args);
((gaobject * ) starred_tuple)->starred = 1;
((gaobject * ) starred_tuple)->starred = true;
Py_SETREF(gi->obj, NULL);
return starred_tuple;
}
Expand Down