Skip to content

gh-90350: Optimize builtin functions min() and max() #30286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 6 commits into from
Dec 11, 2023
Merged

gh-90350: Optimize builtin functions min() and max() #30286

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a9413ab
Builtin functions min() and max() now use METH_FASTCALL
colorfulappl Dec 29, 2021
34142bf
Merge branch 'main' into opt_minmax
hauntsaninja Feb 26, 2023
4dae576
Merge branch 'main' into opt_minmax
serhiy-storchaka Dec 11, 2023
9852e27
Fix compiler warnings.
serhiy-storchaka Dec 11, 2023
610c3d5
Use _PyCFunction_CAST.
serhiy-storchaka Dec 11, 2023
3a0413e
Add a NEWS entry.
serhiy-storchaka Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use _PyCFunction_CAST.
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Dec 11, 2023
commit 610c3d576d6af84cfa576adbdc9d956a964ab892
4 changes: 2 additions & 2 deletions Python/bltinmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3063,8 +3063,8 @@ static PyMethodDef builtin_methods[] = {
BUILTIN_AITER_METHODDEF
BUILTIN_LEN_METHODDEF
BUILTIN_LOCALS_METHODDEF
{"max", (PyCFunction)(void(*)(void))builtin_max, METH_FASTCALL | METH_KEYWORDS, max_doc},
{"min", (PyCFunction)(void(*)(void))builtin_min, METH_FASTCALL | METH_KEYWORDS, min_doc},
{"max", _PyCFunction_CAST(builtin_max), METH_FASTCALL | METH_KEYWORDS, max_doc},
{"min", _PyCFunction_CAST(builtin_min), METH_FASTCALL | METH_KEYWORDS, min_doc},
{"next", _PyCFunction_CAST(builtin_next), METH_FASTCALL, next_doc},
BUILTIN_ANEXT_METHODDEF
BUILTIN_OCT_METHODDEF
Expand Down