Skip to content

bpo-46055: Streamline inner loop for right shifts #30243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdickinson merged 6 commits into from
Dec 27, 2021
Merged

bpo-46055: Streamline inner loop for right shifts #30243

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
056495d
bpo-46055: Streamline inner loop for right shifts
mdickinson Dec 23, 2021
d0f1958
Move declarations to top of function; rename high to lobits
mdickinson Dec 23, 2021
f92f3f8
Now even faster!
mdickinson Dec 23, 2021
76e9a48
Remove unnecessary parentheses
mdickinson Dec 23, 2021
76dc476
Cosmetic changes to align the inner loop with that of long_lshift1
mdickinson Dec 23, 2021
08bb0bb
Merge remote-tracking branch 'upstream/main' into faster-rshift
mdickinson Dec 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unnecessary parentheses
  • Loading branch information
@mdickinson
mdickinson committed Dec 23, 2021
commit 76e9a487c7be6525d927de99f2045259ee1e7509
2 changes: 1 addition & 1 deletion Objects/longobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4516,7 +4516,7 @@ long_rshift1(PyLongObject *a, Py_ssize_t wordshift, digit remshift)
j = wordshift;
twodigits acc = a->ob_digit[j++] >> remshift;
for (i = 0; j < Py_SIZE(a); i++, j++) {
acc |= ((twodigits)(a->ob_digit[j]) << hishift);
acc |= (twodigits)(a->ob_digit[j]) << hishift;
z->ob_digit[i] = acc & PyLong_MASK;
acc >>= PyLong_SHIFT;
}
Expand Down