Skip to content

bpo-46025: Fix a crash in the atexit module for auto-unregistering functions #30002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 3 commits into from
Dec 9, 2021
Merged

bpo-46025: Fix a crash in the atexit module for auto-unregistering functions #30002

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
002b033
bpo-46025: Fix a crash in the atexit module for auto-unregistering fu…
pablogsal Dec 9, 2021
ebc949b
Update Modules/atexitmodule.c
pablogsal Dec 9, 2021
ec3741e
Update Modules/atexitmodule.c
pablogsal Dec 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Modules/atexitmodule.c 
Co-authored-by: Victor Stinner <vstinner@python.org>
  • Loading branch information
@pablogsal @vstinner
pablogsal and vstinner authored Dec 9, 2021
commit ebc949b79da4b1d80931da828fd2aa3d912543f2
2 changes: 1 addition & 1 deletion Modules/atexitmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ atexit_callfuncs(struct atexit_state *state)
continue;
}

// Increment the refcount of cb->func as the call itself may unregister it
// bpo-46025: Increment the refcount of cb->func as the call itself may unregister it
PyObject* the_func = cb->func;
Py_INCREF(the_func);
PyObject *res = PyObject_Call(cb->func, cb->args, cb->kwargs);
Expand Down