Skip to content

GH-89769: Pathlib - do not follow links when checking for precise glob match #29655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barneygale merged 15 commits into from
May 3, 2023
Merged

GH-89769: Pathlib - do not follow links when checking for precise glob match #29655

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
272c1b4
do not follow links when checking for precise glob match
akulakov Nov 20, 2021
70db4c0
update docs for `exists()`
akulakov Nov 20, 2021
cf0f823
add news entry
akulakov Nov 20, 2021
9107f3d
add docstring; fix the doctest error in the documentation
akulakov Nov 20, 2021
4c40ea3
expand test_exists
akulakov Nov 20, 2021
686cd34
fix typo in var name
akulakov Nov 20, 2021
01ec5af
revert typo fix
akulakov Nov 20, 2021
1d03f90
move symlink tests to conditional
akulakov Nov 20, 2021
66700bf
Update Lib/pathlib.py
akulakov May 3, 2023
0e07f88
Update Doc/library/pathlib.rst
akulakov May 3, 2023
071f0f3
Update Lib/pathlib.py
akulakov May 3, 2023
6cff634
Update Misc/NEWS.d/next/Library/2021-11-19-23-37-18.bpo-45606.UW5XE1.rst
akulakov May 3, 2023
3818c31
update docstring
akulakov May 3, 2023
4b6fefc
Merge branch 'main' into 45606-Path-glob-no-follow-symlink
barneygale May 3, 2023
0093d52
Update Doc/library/pathlib.rst
akulakov May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add docstring; fix the doctest error in the documentation
  • Loading branch information
@akulakov
akulakov committed Nov 20, 2021
commit 9107f3d7f13987c933caa0e41b09316619c17958
2 changes: 2 additions & 0 deletions Doc/library/pathlib.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,6 +762,8 @@ call fails (for example because the path doesn't exist).
This method normally follows symlinks; to check if a symlink exists, add
the argument ``follow_symlinks=False``.

::

>>> Path('.').exists()
True
>>> Path('setup.py').exists()
Expand Down
4 changes: 4 additions & 0 deletions Lib/pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1284,6 +1284,10 @@ def link_to(self, target):
def exists(self, follow_symlinks=True):
Comment thread
akulakov marked this conversation as resolved.
Outdated
"""
Whether this path exists.

If path is a symlink: with `follow_symlinks=True`, return True if path
pointed to by the symlink exists; with follow_symlinks=False, return
True if the symlink itself exists.
Comment thread
barneygale marked this conversation as resolved.
Outdated
"""
try:
self.stat(follow_symlinks=follow_symlinks)
Expand Down