Skip to content

bpo-45723: Improve and simplify more configure.ac checks (GH-29485) #29485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiran merged 6 commits into from
Nov 10, 2021
Merged

bpo-45723: Improve and simplify more configure.ac checks (GH-29485) #29485

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6e0fa90
Cache checking for -Wl,--no-as-needed
Nov 9, 2021
35fe25c
Make PY_CHECK_CC_WARNING more efficient
Nov 9, 2021
ad35861
Consolidate AC_MSG_CHECKING and AC_CACHE_VAL
Nov 9, 2021
77f4cad
Nitpick
Nov 9, 2021
de69f18
Use AS_VAR_APPEND in PY_CHECK_CC_WARNING
Nov 9, 2021
79b97e0
Take down one more AC_MSG_RESULT
Nov 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use AS_VAR_APPEND in PY_CHECK_CC_WARNING
  • Loading branch information
Erlend E. Aasland
Erlend E. Aasland committed Nov 9, 2021
commit de69f18aef8ecb7481e0724e2051036438724746
14 changes: 7 additions & 7 deletions configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7091,7 +7091,7 @@ if ${ac_cv_enable_extra_warning+:} false; then :
else

py_cflags=$CFLAGS
CFLAGS="$CFLAGS -Wextra -Werror"
as_fn_append CFLAGS "-Wextra -Werror"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */

Expand Down Expand Up @@ -7202,7 +7202,7 @@ if ${ac_cv_disable_unused_result_warning+:} false; then :
else

py_cflags=$CFLAGS
CFLAGS="$CFLAGS -Wunused-result -Werror"
as_fn_append CFLAGS "-Wunused-result -Werror"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */

Expand Down Expand Up @@ -7244,7 +7244,7 @@ if ${ac_cv_disable_unused_parameter_warning+:} false; then :
else

py_cflags=$CFLAGS
CFLAGS="$CFLAGS -Wunused-parameter -Werror"
as_fn_append CFLAGS "-Wunused-parameter -Werror"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */

Expand Down Expand Up @@ -7282,7 +7282,7 @@ if ${ac_cv_disable_missing_field_initializers_warning+:} false; then :
else

py_cflags=$CFLAGS
CFLAGS="$CFLAGS -Wmissing-field-initializers -Werror"
as_fn_append CFLAGS "-Wmissing-field-initializers -Werror"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */

Expand Down Expand Up @@ -7320,7 +7320,7 @@ if ${ac_cv_enable_sign_compare_warning+:} false; then :
else

py_cflags=$CFLAGS
CFLAGS="$CFLAGS -Wsign-compare -Werror"
as_fn_append CFLAGS "-Wsign-compare -Werror"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */

Expand Down Expand Up @@ -7358,7 +7358,7 @@ if ${ac_cv_enable_unreachable_code_warning+:} false; then :
else

py_cflags=$CFLAGS
CFLAGS="$CFLAGS -Wunreachable-code -Werror"
as_fn_append CFLAGS "-Wunreachable-code -Werror"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */

Expand Down Expand Up @@ -7408,7 +7408,7 @@ if ${ac_cv_enable_strict_prototypes_warning+:} false; then :
else

py_cflags=$CFLAGS
CFLAGS="$CFLAGS -Wstrict-prototypes -Werror"
as_fn_append CFLAGS "-Wstrict-prototypes -Werror"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */

Expand Down
2 changes: 1 addition & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1644,7 +1644,7 @@ AC_DEFUN([PY_CHECK_CC_WARNING], [
AS_VAR_PUSHDEF([py_var], [ac_cv_$1_]m4_normalize($2)[_warning])
AC_CACHE_CHECK(m4_ifblank([$3], [if we can $1 $CC $2 warning], [$3]), [py_var], [
AS_VAR_COPY([py_cflags], [CFLAGS])
AS_VAR_SET([CFLAGS], ["$CFLAGS -W$2 -Werror"])
AS_VAR_APPEND([CFLAGS], ["-W$2 -Werror"])
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])],
[AS_VAR_SET([py_var], [yes])],
[AS_VAR_SET([py_var], [no])])
Expand Down