Skip to content

bpo-40512: Store pointer to interpreter state in a thread local variable #29228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markshannon wants to merge 11 commits into from
Closed

bpo-40512: Store pointer to interpreter state in a thread local variable #29228

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7c7e2b2
Use a thread-local variable to store a pointer to the interpreter-state.
markshannon Oct 25, 2021
73c410b
Add NEWS
markshannon Oct 26, 2021
f22036b
Merge branch 'main' into thread-local-interpreter-state
markshannon Oct 27, 2021
f33f4a4
Revert erroneous change.
markshannon Oct 28, 2021
55cc2e4
Fix misleading comment and formatting.
markshannon Oct 28, 2021
4b83356
Ensure that FatalError is raised for NULL interpreter state in debug …
markshannon Nov 1, 2021
8502145
Merge branch 'main' into thread-local-interpreter-state
markshannon Nov 1, 2021
28bc042
Fixup PY_ZERO and PY_ONE macros.
markshannon Nov 1, 2021
193b646
Merge branch 'main' into thread-local-interpreter-state
markshannon Nov 16, 2021
a30b7e6
Merge branch 'main' into thread-local-interpreter-state
markshannon Dec 6, 2021
3982884
Make _Py_IsMainInterpreter inline again.
markshannon Dec 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make _Py_IsMainInterpreter inline again.
  • Loading branch information
@markshannon
markshannon committed Dec 7, 2021
commit 3982884a299baf93984e98bcfeb607042569383a
9 changes: 7 additions & 2 deletions Include/internal/pycore_pystate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,13 @@ _Py_IsMainThread(void)
return (thread == _PyRuntime.main_thread);
}

extern int
_Py_IsMainInterpreter(PyInterpreterState *interp);
static inline int
_Py_IsMainInterpreter(PyInterpreterState *interp)
{
/* Use directly _PyRuntime rather than tstate->interp->runtime, since
this function is used in performance critical code path (ceval) */
return interp == _PyRuntime.interpreters.main;
}

static inline const PyConfig *
_Py_GetMainConfig(void)
Expand Down
9 changes: 0 additions & 9 deletions Python/pystate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2125,15 +2125,6 @@ _PyThreadState_PopFrame(PyThreadState *tstate, InterpreterFrame * frame)
_Py_THREAD_LOCAL PyInterpreterState *_py_current_interpreter = NULL;
#endif

int
_Py_IsMainInterpreter(PyInterpreterState *interp)
{
/* Use directly _PyRuntime rather than tstate->interp->runtime, since
this function is used in performance critical code path (ceval) */
return interp == _PyRuntime.interpreters.main;
}


#ifdef __cplusplus
}
#endif