Skip to content

bpo-43137: webbrowser: Replace gvfs-open and gnome-open with "gio open" #29154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 4 commits into from
Nov 25, 2021
Merged

bpo-43137: webbrowser: Replace gvfs-open and gnome-open with "gio open" #29154

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4fd89aa
bpo-43137: webbrowser: Prefer gio open over gvfs-open
smcv Sep 22, 2020
251ea9c
bpo-43137: webbrowser: Never invoke gnome-open
smcv Oct 22, 2021
aed1ba5
bpo-43137: webbrowser: Don't run gvfs-open on GNOME
smcv Oct 22, 2021
c5f9658
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bpo-43137: webbrowser: Never invoke gnome-open 
gnome-open was part of GNOME 2, which was superseded in around 2010 and
is unmaintained. The replacement was gvfs-open, which was subsequently
replaced by gio(1) (as used in the previous commit).

Signed-off-by: Simon McVittie <smcv@debian.org>
  • Loading branch information
@smcv
smcv committed Oct 22, 2021
commit 251ea9cf24cebfa45456f782b4ebfd28f55acc4c
4 changes: 0 additions & 4 deletions Lib/webbrowser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,10 +471,6 @@ def register_X_browsers():
if "GNOME_DESKTOP_SESSION_ID" in os.environ and shutil.which("gvfs-open"):
register("gvfs-open", None, BackgroundBrowser("gvfs-open"))

# The default GNOME browser before 2008
if "GNOME_DESKTOP_SESSION_ID" in os.environ and shutil.which("gnome-open"):
register("gnome-open", None, BackgroundBrowser("gnome-open"))

# The default KDE browser
if "KDE_FULL_SESSION" in os.environ and shutil.which("kfmclient"):
register("kfmclient", Konqueror, Konqueror("kfmclient"))
Expand Down