Skip to content

bpo-42064: Convert sqlite3 global state to module state #29073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 4 commits into from
Oct 27, 2021
Merged

bpo-42064: Convert sqlite3 global state to module state #29073

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99cdaff
bpo-42064: Convert global state to module state
Oct 19, 2021
ebae5a8
Address review: fix module state in Row tp_richcompare
Oct 20, 2021
7ac66b6
Address review: drop pysqlite_get_state_by_cls in favour of pysqlite_…
Oct 20, 2021
5da6ded
Address review
Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review: fix module state in Row tp_richcompare
  • Loading branch information
Erlend E. Aasland
Erlend E. Aasland committed Oct 20, 2021
commit ebae5a8c0f6844bf58f6c0b640ffcd823ea8cf64
2 changes: 1 addition & 1 deletion Modules/_sqlite/row.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ static PyObject* pysqlite_row_richcompare(pysqlite_Row *self, PyObject *_other,
if (opid != Py_EQ && opid != Py_NE)
Py_RETURN_NOTIMPLEMENTED;

pysqlite_state *state = pysqlite_get_state_by_cls(Py_TYPE(self));
pysqlite_state *state = pysqlite_get_state_by_type(Py_TYPE(self));
if (PyObject_TypeCheck(_other, state->RowType)) {
pysqlite_Row *other = (pysqlite_Row *)_other;
int eq = PyObject_RichCompareBool(self->description, other->description, Py_EQ);
Expand Down