Skip to content

bpo-42222: Remove deprecated support for non-integer values #28983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhettinger merged 10 commits into from
Oct 16, 2021
Merged

bpo-42222: Remove deprecated support for non-integer values #28983

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8cf5d54
Remove deprecated non-integer support
rhettinger Oct 15, 2021
738e090
Add doc updates
rhettinger Oct 15, 2021
cc89346
Add blurb
rhettinger Oct 15, 2021
eb76fbd
index() version
rhettinger Oct 15, 2021
e509f7f
Update tests
rhettinger Oct 15, 2021
a87fcac
Tweek wording for the versionchanged entry
rhettinger Oct 15, 2021
59a734b
Improve test organization
rhettinger Oct 15, 2021
8fe5c51
Improve docstring
rhettinger Oct 15, 2021
9a014ea
More detailed error messages
rhettinger Oct 16, 2021
e7a217f
Improve docstring
rhettinger Oct 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve test organization
  • Loading branch information
@rhettinger
rhettinger committed Oct 15, 2021
commit 59a734b5b696ab30bca64e393c86b0fed7e3a36f
13 changes: 8 additions & 5 deletions Lib/test/test_random.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,12 +483,16 @@ def test_randrange_nonunit_step(self):
def test_randrange_errors(self):
raises_value_error = partial(self.assertRaises, ValueError, self.gen.randrange)
raises_type_error = partial(self.assertRaises, TypeError, self.gen.randrange)

# Empty range
raises_value_error(3, 3)
raises_value_error(-721)
raises_value_error(0, 100, -12)
# Non-integer start/stop

# Zero step
raises_value_error(0, 42, 0)

# Non-integer start/stop/step
raises_type_error(3.14159)
raises_type_error(3.0)
raises_type_error(Fraction(3, 1))
Expand All @@ -498,10 +502,9 @@ def test_randrange_errors(self):
raises_type_error(0, Fraction(2, 1))
raises_type_error(0, '2')

# Zero and non-integer step
raises_value_error(0, 42, 0)
raises_type_error(0, 42, 0.0)
raises_type_error(0, 0, 0.0)
# Non-integer step
raises_type_error(0, 42, 1.0)
raises_type_error(0, 0, 1.0)
raises_type_error(0, 42, 3.14159)
raises_type_error(0, 42, 3.0)
raises_type_error(0, 42, Fraction(3, 1))
Expand Down