Skip to content

bpo-21736: Set __file__ on frozen stdlib modules. #28656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 18 commits into from
Oct 14, 2021
Merged

bpo-21736: Set __file__ on frozen stdlib modules. #28656

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
5c538f5
Set __file__ on frozen modules if possible.
ericsnowcurrently Sep 29, 2021
62e3c16
Set __file__ based on "origname".
ericsnowcurrently Sep 29, 2021
6aaba14
Fix it
ericsnowcurrently Oct 1, 2021
f4d6db6
Fix up early-imported frozen modules.
ericsnowcurrently Sep 30, 2021
d8e19e0
Add a NEWS entry.
ericsnowcurrently Oct 1, 2021
ac5b7c1
Drop an unncessary comment.
ericsnowcurrently Oct 5, 2021
79c1035
Make sure frozen modules are fixed up properly.
ericsnowcurrently Oct 5, 2021
322cfd1
Return a memoryview from _imp.find_frozen().
ericsnowcurrently Oct 12, 2021
4f5160e
Use PyObject_GetBuffer() in _imp.get_frozen_object().
ericsnowcurrently Oct 13, 2021
dc152db
Stop storing the marshaled data in spec.loader_state.
ericsnowcurrently Oct 13, 2021
9687202
Empty initializers are not allowed.
ericsnowcurrently Oct 13, 2021
3685dd2
Keep _set_fileattr False if there is no location.
ericsnowcurrently Oct 14, 2021
549d395
Drop some unnecessary uses of "state".
ericsnowcurrently Oct 14, 2021
1decabf
Make an assertion more precise.
ericsnowcurrently Oct 14, 2021
4d47f30
Move a TODO comment.
ericsnowcurrently Oct 14, 2021
d6eea90
All modules without "origname" in _fix_up_module().
ericsnowcurrently Oct 14, 2021
866fdad
Add a comment about why we don't preserve the data in find_spec().
ericsnowcurrently Oct 14, 2021
5cba3d1
Fix a typo in a comment.
ericsnowcurrently Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Set __file__ on frozen modules if possible.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Oct 5, 2021
commit 5c538f5da7e97ead989d55490753f42f0b887634
20 changes: 19 additions & 1 deletion Lib/importlib/_bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,13 +850,19 @@ def find_spec(cls, fullname, path=None,>
if info is None:
return None
data, ispkg, origname = info
filename = pkgdir = None
spec = spec_from_loader(fullname, cls,
origin=cls._ORIGIN,
is_package=ispkg)
spec.loader_state = type(sys.implementation)(
data=data,
filename=filename,
origname=origname,
)
if ispkg and filename:
assert filename.endswith('__init__.py'), filename
assert pkgdir, pkgdir
spec.submodule_search_locations.insert(0, pkgdir)
return spec

@classmethod
Expand All @@ -873,7 +879,16 @@ def find_module(cls, fullname, path=None):

@staticmethod
def create_module(spec):
"""Use default semantics for module creation."""
"""Set __file__, if able."""
module = _new_module(spec.name)
try:
filename = spec.loader_state.filename
except AttributeError:
pass
else:
if filename:
module.__file__ = filename
return module

@staticmethod
def exec_module(module):
Expand Down Expand Up @@ -905,6 +920,9 @@ def load_module(cls, fullname):
# Warning about deprecation implemented in _load_module_shim().
return _load_module_shim(cls, fullname)

# XXX We should also add get_filename(), but when we do we need
# to fix spec_from_loader().

@classmethod
@_requires_frozen
def get_code(cls, fullname):
Expand Down