Skip to content

bpo-29469: Move constant folding at AST level #2858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 20 commits into from
Dec 14, 2017
Merged

bpo-29469: Move constant folding at AST level #2858

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
b0c4745
bpo-29469: Move constant folding at AST level
methane Jul 25, 2017
a4edbc3
stable visitor order
methane Jul 26, 2017
9b0f10c
remove simple constant folding from peephole
methane Jul 26, 2017
a603d5b
stabilize prototype order
methane Jul 26, 2017
e2ae3fd
Merge remote-tracking branch 'origin/master' into ast-constant-fold
methane Oct 6, 2017
43ae08a
Merge remote-tracking branch 'origin/master' into ast-constant-fold
methane Dec 4, 2017
04fb56c
Remove code generator for ast_opt.c
methane Dec 12, 2017
5da0739
remove noop functions
methane Dec 12, 2017
af2a46b
make regen-all
methane Dec 12, 2017
078c1ed
Fix test.test_plistlib.TestPlistlib.test_tuple_members
methane Dec 12, 2017
b64240d
Merge remote-tracking branch 'origin/master' into ast-constant-fold
methane Dec 13, 2017
89c54ad
return type should be separated line
methane Dec 13, 2017
94160d4
Use Py_UNREACHABLE()
methane Dec 13, 2017
e416c5f
Fix KeyboardInterrupt handling
methane Dec 13, 2017
3f34890
Use designated initializer
methane Dec 13, 2017
e1f466d
Fix error handling in fold_binop()
methane Dec 13, 2017
1f3fc8e
fix
methane Dec 13, 2017
17396dc
Add NEWS entry
methane Dec 13, 2017
de2effe
fix
methane Dec 13, 2017
30edda9
make regen-all
methane Dec 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use Py_UNREACHABLE()
  • Loading branch information
@methane
methane committed Dec 13, 2017
commit 94160d4ac5fd44903233019b0eef680c3421b056
5 changes: 2 additions & 3 deletions Python/ast_opt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,15 @@ get_const_value(expr_ty e)
case NameConstant_kind:
return e->v.NameConstant.value;
default:
assert(!is_const(e));
return NULL;
Py_UNREACHABLE();
}
}

static int
make_const(expr_ty node, PyObject *val, PyArena *arena)
{
if (val == NULL) {
if(!PyErr_ExceptionMatches(PyExc_KeyboardInterrupt))
if (!PyErr_ExceptionMatches(PyExc_KeyboardInterrupt))
PyErr_Clear();
return 1;

@serhiy-storchaka serhiy-storchaka Dec 12, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it return 0 in case of KeyboardInterrupt?

}
Expand Down