Skip to content

bpo-24139: Add support for SQLite extended result codes #28076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 23 commits into from
Nov 2, 2021
Merged

bpo-24139: Add support for SQLite extended result codes #28076

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
b263f0f
Add extended result codes as module constants
Aug 17, 2021
c8c0e96
Use extended result code to add exception attributes
Aug 17, 2021
9c08365
Add ifdefs for extended error codes
Aug 17, 2021
8db2828
Add test for extended error codes
Aug 19, 2021
0275ffd
Add NEWS item
Aug 30, 2021
0e95901
Fix windows tests
Aug 30, 2021
0a2efd9
Fix ifdefs for extended result codes
Aug 31, 2021
b1a2625
Fix tests again
Aug 31, 2021
a30ffb3
Add extended error codes from upcoming SQLite 3.37.0
Aug 31, 2021
63347d8
Squeeze a couple of lines in test_module_constants()
Sep 1, 2021
988d7cc
Merge branch 'main' into sqlite-extended-error-codes
Sep 14, 2021
fbc1526
Address review: add link to SQLite docs
Sep 19, 2021
8e6c58c
Add links to SQLite release docs
Sep 20, 2021
a36a6b9
Fix #if's for error codes between SQLite 3.8.2 and 3.8.10
Sep 20, 2021
59da713
Add support for the SQLITE_RANGE primary result code
Sep 20, 2021
f6a9bbe
Fix test_extended_error_code_on_exception version requirement
Sep 21, 2021
933f57b
What's New
Sep 21, 2021
631e4d5
Use managed connect in the added test
Sep 21, 2021
54b1ceb
Merge branch 'main' into sqlite-extended-error-codes
Sep 21, 2021
26517fc
Improve comment
Sep 22, 2021
b01303a
Merge branch 'main' into sqlite-extended-error-codes
Nov 1, 2021
1f39d8d
Remove 3.37.0 (dev) error codes. 3.37 is still in development
Nov 1, 2021
3cb5998
Remove dev (3.37.0) flags from tests as well
Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix windows tests
  • Loading branch information
Erlend E. Aasland
Erlend E. Aasland committed Aug 30, 2021
commit 0e9590103aab3c6eaa402ba3d786fe749b5fd718
9 changes: 7 additions & 2 deletions Lib/sqlite3/test/dbapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,12 +270,17 @@ def test_module_constants(self):

def test_error_code_on_exception(self):
err_msg = "unable to open database file"
if sys.platform.startswith("win"):
err_code = SQLITE_CANTOPEN_ISDIR
else:
err_code = SQLITE_CANTOPEN

with temp_dir() as db:
with self.assertRaisesRegex(sqlite.Error, err_msg) as cm:
sqlite.connect(db)
e = cm.exception
self.assertEqual(e.sqlite_errorcode, sqlite.SQLITE_CANTOPEN)
self.assertEqual(e.sqlite_errorname, "SQLITE_CANTOPEN")
self.assertEqual(e.sqlite_errorcode, err_code)
self.assertTrue(e.sqlite_errorname.startswith("SQLITE_CANTOPEN"))

@unittest.skipIf(sqlite.sqlite_version_info <= (3, 10, 0),
"Requires SQLite 3.10.0 or newer")
Expand Down