Skip to content

bpo-30969: Fix docs about the comparison in absence of __contains__ #2761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
csabella merged 4 commits into from
May 30, 2019
Merged

bpo-30969: Fix docs about the comparison in absence of __contains__ #2761

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6d411c6
Fix the eq check that is used in absence of `__contains__`
ztane Jul 19, 2017
29abde0
lowercase the true, as it need not be `True`.
ztane Jul 19, 2017
511406d
Add the missing space here.
ztane Jul 19, 2017
b4f285f
Fix trailing whitespace
csabella May 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lowercase the true, as it need not be True.
  • Loading branch information
@ztane
ztane authored Jul 19, 2017
commit 29abde02d45c8ac4c3e9e4645e84ccdeed8a601a
2 changes: 1 addition & 1 deletion Doc/reference/expressions.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1444,7 +1444,7 @@ y`` returns ``True`` if ``y.__contains__(x)`` returns a true value, and

For user-defined classes which do not define :meth:`__contains__` but do define
:meth:`__iter__`, ``x in y`` is ``True`` if some value ``z``, for which the

@tirkarthi tirkarthi Jan 8, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ztane trailing space in the three lines are causing CI failure. Removing them will fix the issue. Thanks for the patch.

Doc git:(pr_2761) python3 tools/rstlint.py -i tools -i ./venv -i README.rst
[1] reference/expressions.rst:1446: trailing whitespace
[1] reference/expressions.rst:1447: trailing whitespace
[1] reference/expressions.rst:1448: trailing whitespace
3 problems with severity 1 found.

expression``x is z or x == z`` is True, is produced while iterating over ``y``.
expression``x is z or x == z`` is true, is produced while iterating over ``y``.
If an exception is raised during the iteration, it is as if :keyword:`in` raised
that exception.

Expand Down