Skip to content

bpo-44688: Remove ASCII limitation from sqlite3 collation names #27395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 7 commits into from
Jul 29, 2021
Merged

bpo-44688: Remove ASCII limitation from sqlite3 collation names #27395

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3f9e3c7
bpo-44688: sqlite3 now accepts UTF8 collation names
Jul 20, 2021
13e17db
Docs
Jul 20, 2021
ea65d23
Address review: adjust NEWS entry wording
Jul 28, 2021
f34461d
Address review: revert test method renaming
Jul 28, 2021
1f0e959
Address review: Improve What's New wording
Jul 28, 2021
74f7108
Address review: mention previous limitation in the docs
Jul 28, 2021
dfa343f
Remove trailing whitespace
Jul 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Docs
  • Loading branch information
Erlend E. Aasland
Erlend E. Aasland committed Jul 27, 2021
commit 13e17db91a577c01f3a7fa842b4a118d5b4eec64
5 changes: 5 additions & 0 deletions Doc/whatsnew/3.11.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,11 @@ sqlite3
:meth:`~sqlite3.Connection.set_authorizer`.
(Contributed by Erlend E. Aasland in :issue:`44491`.)

* :meth:`~sqlite3.Connection.create_collation` now accepts UTF8 collation
names. Collation names with invalid characters now raise
:exc:`UnicodeEncodeError` instead of :exc:`sqlite3.ProgrammingError`.
(Contributed by Erlend E. Aasland in :issue:`44688`.)

Comment thread
erlend-aasland marked this conversation as resolved.
Outdated

Removed
=======
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2021-07-20-23-28-26.bpo-44688.buFgz3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
:meth:`sqlite3.Connection.create_collation` now accepts UTF8 collation
names. Patch by Erlend E. Aasland.
Comment thread
erlend-aasland marked this conversation as resolved.
Outdated