Skip to content

bpo-28879 : add date if missing in smtplib.send_message #2655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elafontaine wants to merge 6 commits into from
Closed

bpo-28879 : add date if missing in smtplib.send_message #2655

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
943ee6e
bpo-28879 : add date if missing in smtplib.send_message
elafontaine Jul 11, 2017
9a8cdc2
bpo-28879 : add date if missing in smtplib.send_message part 2
elafontaine Jul 11, 2017
0c43644
bpo-28879 : Mock the date on the Test Case + Fix Typo
elafontaine Jul 20, 2017
aaefe85
bpo-28879 : Fix test case with less '\'
elafontaine Jul 20, 2017
9c1a121
bpo-28879 : escape the date example string
elafontaine Aug 3, 2017
178bc12
Adding news file to advertise changes done by this PR.
Jan 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bpo-28879 : escape the date example string
  • Loading branch information
@elafontaine
elafontaine committed Aug 3, 2017
commit 9c1a12176314524d15ad2190e4736e15a5a820a4
2 changes: 1 addition & 1 deletion Lib/test/test_smtplib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ def testSendMessageAddDateIfMissing(self, mocked_date_obj):
mexpect = '%s%s\n%s' % (MSG_BEGIN, m.as_string(), MSG_END)
self.assertEqual(self.output.getvalue(), mexpect)
debugout = smtpd.DEBUGSTREAM.getvalue()
Date = re.compile(''.join(("\\nDate: ", current_date)), re.MULTILINE)
Date = re.compile(''.join(("\\\\nDate: ", re.escape(current_date))), re.MULTILINE)
self.assertRegex(debugout, Date)


Expand Down