Skip to content

bpo-42972: Track sqlite3 statement objects #26475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 5 commits into from
Jun 1, 2021
Merged

bpo-42972: Track sqlite3 statement objects #26475

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
36ae3eb
bpo-42972: Track sqlite3 statement objects
May 31, 2021
1b0f583
Allocate and track statement objects in pysqlite_statement_create
Jun 1, 2021
0a6ca75
Remove now unused constants
Jun 1, 2021
df284eb
Improve error message
Jun 1, 2021
4f03b79
Group and order member initialisation
Jun 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
bpo-42972: Track sqlite3 statement objects
  • Loading branch information
Erlend E. Aasland
Erlend E. Aasland committed May 31, 2021
commit 36ae3eb25ab9c1c7f8d159a2ac3a000d66dd3ed8
1 change: 1 addition & 0 deletions Modules/_sqlite/connection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1363,6 +1363,7 @@ pysqlite_connection_call(pysqlite_Connection *self, PyObject *args,
statement->in_weakreflist = NULL;

rc = pysqlite_statement_create(statement, self, sql);
PyObject_GC_Track(statement);
if (rc != SQLITE_OK) {
if (rc == PYSQLITE_TOO_MUCH_SQL) {
PyErr_SetString(pysqlite_Warning, "You can only execute one statement at a time.");
Expand Down
1 change: 1 addition & 0 deletions Modules/_sqlite/cursor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,6 +512,7 @@ _pysqlite_query_execute(pysqlite_Cursor* self, int multiple, PyObject* operation
goto error;
}
rc = pysqlite_statement_create(self->statement, self->connection, operation);
Comment thread
erlend-aasland marked this conversation as resolved.
Resolved
PyObject_GC_Track(self->statement);
if (rc != SQLITE_OK) {
Py_CLEAR(self->statement);
goto error;
Expand Down