Skip to content

bpo-42972: Fully support GC for _winapi.Overlapped #26381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 6 commits into from
May 28, 2021
Merged

bpo-42972: Fully support GC for _winapi.Overlapped #26381

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0fa0217
tp_traverse for _winapi.Overlapped
Fidget-Spinner May 26, 2021
9f3ca36
GC track the object
Fidget-Spinner May 26, 2021
96f0d0e
move untrack down to a safer place
Fidget-Spinner May 26, 2021
0493de0
add module m_traverse, clear, free - fully implement the GC protocol …
Fidget-Spinner May 26, 2021
fc3e774
static int -> static void
Fidget-Spinner May 26, 2021
78113cc
Apply victor's suggestions
Fidget-Spinner May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
GC track the object
  • Loading branch information
@Fidget-Spinner
Fidget-Spinner committed May 26, 2021
commit 9f3ca365d75330a72bfe0404893b675937f464be
2 changes: 2 additions & 0 deletions Modules/_winapi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,8 @@ new_overlapped(PyObject *module, HANDLE handle)
memset(&self->write_buffer, 0, sizeof(Py_buffer));
/* Manual reset, initially non-signalled */
self->overlapped.hEvent = CreateEvent(NULL, TRUE, FALSE, NULL);

PyObject_GC_Track(self);
return self;
}

Expand Down