Skip to content

bpo-30779: IDLE -- Factor ConfigChanges class from configdialog, put in config; test. #2612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terryjreedy merged 15 commits into from
Jul 7, 2017
Merged

bpo-30779: IDLE -- Factor ConfigChanges class from configdialog, put in config; test. #2612

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d39a5ec
Make dump a function; run unittest in 'if __name__:'.
terryjreedy Jul 6, 2017
32ae959
Add class ConfigChanges (changes_class_v4.py on issue).
terryjreedy Jul 6, 2017
a8efe0f
Make sure that filesystem not touched with empty file name.
terryjreedy Jul 6, 2017
1a9c0d8
Test ConfigChanges and modify as needed.
terryjreedy Jul 7, 2017
3f381a3
Tweaks to config and test while editing configdialog.
terryjreedy Jul 7, 2017
f22fc6e
Initial revisions of configdialog as in tracker msg297804.
terryjreedy Jul 7, 2017
6e6f4ee
Revise configdialog tests to match other changes. All pass.
terryjreedy Jul 7, 2017
e3e5d5e
Remove configdialog functions reproduced in new class.
terryjreedy Jul 7, 2017
10c8681
Whitespace
terryjreedy Jul 7, 2017
6d2e6dd
Changes inspired by Louie's comments.
terryjreedy Jul 7, 2017
ed50c54
Merge remote-tracking branch 'origin/master' into cf
terryjreedy Jul 7, 2017
b8a714f
Merge remote-tracking branch 'origin/master' into cf
terryjreedy Jul 7, 2017
8c708cc
Improve save_all docstring as per Louie's comment.
terryjreedy Jul 7, 2017
67d5ea1
Config changes responding to Cheryl's comments.
terryjreedy Jul 7, 2017
393f5ec
Remove unused configdialog.GetDefaultItems.
terryjreedy Jul 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Config changes responding to Cheryl's comments.
  • Loading branch information
@terryjreedy
terryjreedy committed Jul 7, 2017
commit 67d5ea143b146570840bc14c26cdedfd15ea02b6
6 changes: 3 additions & 3 deletions Lib/idlelib/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ class IdleConf:
(user home dir)/.idlerc/config-{config-type}.cfg
"""
def __init__(self):
self.config_types = ('main', 'extensions', 'highlight', 'keys')
self.config_types = ('main', 'highlight', 'keys', 'extensions')
self.defaultCfg = {}
self.userCfg = {}
self.cfg = {} # TODO use to select userCfg vs defaultCfg
Expand Down Expand Up @@ -800,7 +800,7 @@ class ConfigChanges(dict):
def __init__(self):
"Create a page for each configuration file"
self.pages = [] # List of unhashable dicts.
for config_type in ('main', 'highlight', 'keys', 'extensions'):
for config_type in idleConf.config_types:
self[config_type] = {}
self.pages.append(self[config_type])

Expand Down Expand Up @@ -828,7 +828,7 @@ def save_option(config_type, section, item, value):
def save_all(self):
"""Save configuration changes to the user config file.

When clear self in preparation for additional changes.
Then clear self in preparation for additional changes.
"""
idleConf.userCfg['main'].Save()
for config_type in self:
Expand Down
2 changes: 1 addition & 1 deletion Lib/idlelib/idle_test/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ class ChangesTest(unittest.TestCase):

empty = {'main':{}, 'highlight':{}, 'keys':{}, 'extensions':{}}

def load(self):
def load(self): # Test_add_option verifies that this works.
changes = self.changes
changes.add_option('main', 'Msec', 'mitem', 'mval')
changes.add_option('highlight', 'Hsec', 'hitem', 'hval')
Expand Down