Skip to content

bpo-44002: Switch to lru_cache in urllib.parse. #25798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 7 commits into from
May 12, 2021
Merged

bpo-44002: Switch to lru_cache in urllib.parse. #25798

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
630dd0a
bpo-44002: Switch to lru_cache in urllib.parse.
gpshead May 1, 2021
7397c2c
Use the default lru_cache size.
gpshead May 2, 2021
8a54534
Use a typed lru_cache on urlsplit.
gpshead May 2, 2021
7b70e99
Restore the list comprehensions.
gpshead May 2, 2021
c2dbd84
don't deprecate clear_cache().
gpshead May 3, 2021
6c02506
Merge remote-tracking branch 'upstream/main' into non-90s-urlparse-cache
gpshead May 11, 2021
1129c9b
Add a test for the module level __getattr__().
gpshead May 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add a test for the module level __getattr__().
  • Loading branch information
@gpshead
gpshead committed May 11, 2021
commit 1129c9b4301de4faaa9101df4c0c6b868458f46b
5 changes: 5 additions & 0 deletions Lib/test/test_urlparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1050,6 +1050,11 @@ def test_Quoter_repr(self):
def test_clear_cache_for_code_coverage(self):
urllib.parse.clear_cache()

def test_urllib_parse_getattr_failure(self):
"""Test that urllib.parse.__getattr__() fails correctly."""
with self.assertRaises(AttributeError):
unused = urllib.parse.this_does_not_exist

def test_all(self):
expected = []
undocumented = {
Expand Down