zooba · Dec 9, 2022 · May 1, 2021 · May 2, 2021 · May 2, 2021 · May 2, 2021
diff --git a/Misc/NEWS.d/next/Windows/2021-05-02-15-29-33.bpo-43984.U92jiv.rst b/Misc/NEWS.d/next/Windows/2021-05-02-15-29-33.bpo-43984.U92jiv.rst
@@ -0,0 +1 @@
+Update winreg.SetValueEx to make sure the value set is not -1.
@@ -579,6 +579,10 @@ Py2Reg(PyObject *value, DWORD typ, BYTE **retDataBuf, DWORD *retDataSize)
             }
             else {
                 DWORD d = PyLong_AsUnsignedLong(value);
+                if ((d == (DWORD)(-1)) && PyErr_Occurred()) {
+                    PyMem_Free(retDataBuf);
+                    return FALSE;
+                }
                 memcpy(*retDataBuf, &d, sizeof(DWORD));
             }
             break;
@@ -597,6 +601,10 @@ Py2Reg(PyObject *value, DWORD typ, BYTE **retDataBuf, DWORD *retDataSize)
             }
             else {
                 DWORD64 d = PyLong_AsUnsignedLongLong(value);
+                if ((d == (DWORD64)(-1)) && PyErr_Occurred()) {
+                    PyMem_Free(retDataBuf);
+                    return FALSE;
+                }
                 memcpy(*retDataBuf, &d, sizeof(DWORD64));
             }
             break;
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Update winreg.SetValueEx to make sure the value set is not -1.
Comment thread shreyanavigyan marked this conversation as resolved. Outdated