Skip to content

bpo-37903: implement shell sidebar mouse interactions #25708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terryjreedy merged 15 commits into from
May 3, 2021
Merged

bpo-37903: implement shell sidebar mouse interactions #25708

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7428643
bpo-37903: implement shell sidebar mouse interactions
taleinat Apr 28, 2021
c7dc3f4
working shell sidebar context menu
taleinat Apr 29, 2021
1172040
add tests for shell sidebar context menu actions
taleinat Apr 30, 2021
9a2fcd9
cleanup and improved doc-strings
taleinat Apr 30, 2021
823e6a0
remove whitespace in otherwise empty line
taleinat Apr 30, 2021
4f63ef7
fix: remove unnecessary event args from sidebar context-menu handlers
taleinat May 1, 2021
ad28ec1
add "Copy only code" shell sidebar context-menu option
taleinat May 1, 2021
d790175
disable shell sidebar context-menu copying when there is no selection
taleinat May 1, 2021
b20c959
fix recall of auto-completed input
taleinat May 1, 2021
aa11033
Merge branch 'master' into idle-shell-sidebar-selection
taleinat May 1, 2021
7d1c5f5
add "Copy with prompts" and "Copy only code" to shell's context menu too
taleinat May 1, 2021
90b0ef8
fix sidebar tests
taleinat May 1, 2021
3c711c0
remove "copy-only-code" feature
taleinat May 1, 2021
cf0f0f4
Merge remote-tracking branch 'upstream/master' into pr_25708
terryjreedy May 3, 2021
a1e6bf1
News and What's New items.
terryjreedy May 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
disable shell sidebar context-menu copying when there is no selection
  • Loading branch information
@taleinat
taleinat committed May 1, 2021
commit d790175e1df5d1e2e26a324fd59389e9ecd96e86
13 changes: 9 additions & 4 deletions Lib/idlelib/sidebar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@

def get_lineno(text, index):
"""Return the line number of an index in a Tk text widget."""
return int(float(text.index(index)))
text_index = text.index(index)
return int(float(text_index)) if text_index else None


def get_end_linenumber(text):
Expand Down Expand Up @@ -440,11 +441,15 @@ def bind_events(self):

def context_menu_event(self, event):
rmenu = tk.Menu(self.main_widget, tearoff=0)
rmenu.add_command(label='Copy', command=self.rmenu_copy_handler)
has_selection = bool(self.text.tag_nextrange('sel', '1.0'))
rmenu.add_command(label='Copy', command=self.rmenu_copy_handler,
state='normal' if has_selection else 'disabled')
rmenu.add_command(label='Copy with prompts',
command=self.rmenu_copy_with_prompts_handler)
command=self.rmenu_copy_with_prompts_handler,
state='normal' if has_selection else 'disabled')
rmenu.add_command(label='Copy only code',
command=self.rmenu_copy_only_code_handler)
command=self.rmenu_copy_only_code_handler,
state='normal' if has_selection else 'disabled')
rmenu.tk_popup(event.x_root, event.y_root)
return "break"

Expand Down