Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions Lib/_pyio.py
Original file line number Diff line number Diff line change
Expand Up @@ -311,18 +311,19 @@ def _open_code_with_warning(path):
open_code = _open_code_with_warning


class DocDescriptor:
"""Helper for builtins.open.__doc__
"""
def __get__(self, obj, typ=None):
return (
"open(file, mode='r', buffering=-1, encoding=None, "
"errors=None, newline=None, closefd=True)\n\n" +
open.__doc__)


# bpo-43680: Alias to open() kept for backward compatibility
OpenWrapper = open
def __getattr__(name):
if name == "OpenWrapper":
import warnings
warnings.warn('OpenWrapper is deprecated, use open instead',
DeprecationWarning, stacklevel=2)
# bpo-43680: Until Python 3.9, _pyio.open was not a static method and
# builtins.open was set to OpenWrapper to not become a bound method
# when set to a class variable. _io.open is a built-in function whereas
# _pyio.open is a Python function. In Python 3.10, _pyio.open() is now
# a static method, and builtins.open() is now io.open().
OpenWrapper = _io.open
return OpenWrapper
raise AttributeError(name)


# In normal operation, both `UnsupportedOperation`s should be bound to the
Expand Down
16 changes: 15 additions & 1 deletion Lib/io.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,21 @@
BufferedWriter, BufferedRWPair, BufferedRandom,
IncrementalNewlineDecoder, text_encoding, TextIOWrapper)

OpenWrapper = _io.open # for compatibility with _pyio

def __getattr__(name):
if name == "OpenWrapper":
import warnings
warnings.warn('OpenWrapper is deprecated, use open instead',
DeprecationWarning, stacklevel=2)
# bpo-43680: Until Python 3.9, _pyio.open was not a static method and
# builtins.open was set to OpenWrapper to not become a bound method
# when set to a class variable. _io.open is a built-in function whereas
# _pyio.open is a Python function. In Python 3.10, _pyio.open() is now
# a static method, and builtins.open() is now io.open().
OpenWrapper = _io.open
Comment thread
vstinner marked this conversation as resolved.
Outdated
return OpenWrapper
raise AttributeError(name)


# Pretend this exception was created here.
UnsupportedOperation.__module__ = "io"
Expand Down
2 changes: 0 additions & 2 deletions Lib/test/test_io.py
Original file line number Diff line number Diff line change
Expand Up @@ -4598,8 +4598,6 @@ def load_tests(*args):
globs = globals()
c_io_ns.update((x.__name__, globs["C" + x.__name__]) for x in mocks)
py_io_ns.update((x.__name__, globs["Py" + x.__name__]) for x in mocks)
# Avoid turning open into a bound method.
py_io_ns["open"] = pyio.OpenWrapper
for test in tests:
if test.__name__.startswith("C"):
for name, obj in c_io_ns.items():
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Deprecate io.OpenWrapper and _pyio.OpenWrapper: use io.open and _pyio.open
instead. Until Python 3.9, _pyio.open was not a static method and
builtins.open was set to OpenWrapper to not become a bound method when set
to a class variable. _io.open is a built-in function whereas _pyio.open is a
Python function. In Python 3.10, _pyio.open() is now a static method, and
builtins.open() is now io.open().