Skip to content

bpo-43779: _PyArena_AddPyObject only steals a ref on success #25289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 1 commit into from
Apr 8, 2021
Merged

bpo-43779: _PyArena_AddPyObject only steals a ref on success #25289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
_PyArena_AddPyObject only steals a ref on success
  • Loading branch information
Erlend E. Aasland
Erlend E. Aasland committed Apr 8, 2021
commit dee38e46b439376b210ac6f564d47e01ee42f640
5 changes: 4 additions & 1 deletion Parser/pegen.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,7 +690,10 @@ _PyPegen_fill_token(Parser *p)
if (t->bytes == NULL) {
return -1;
}
_PyArena_AddPyObject(p->arena, t->bytes);
if (_PyArena_AddPyObject(p->arena, t->bytes) < 0) {
Py_DECREF(t->bytes);
return -1;
}

int lineno = type == STRING ? p->tok->first_lineno : p->tok->lineno;
const char *line_start = type == STRING ? p->tok->multi_line_start : p->tok->line_start;
Expand Down