Skip to content

bpo-43433: Reattach query parameters after parsing URI #25045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Rosuav wants to merge 1 commit into from
Closed

bpo-43433: Reattach query parameters after parsing URI #25045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
xmlrpc: Reattach query parameters after parsing URI
  • Loading branch information
@Rosuav
Rosuav committed Mar 27, 2021
commit f99ae03eb4aa2c6c036e65652616b13e37484d5e
2 changes: 2 additions & 0 deletions Lib/xmlrpc/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1426,6 +1426,8 @@ def __init__(self, uri, transport=None, encoding=None, verbose=False,
raise OSError("unsupported XML-RPC protocol")
self.__host = p.netloc
self.__handler = p.path or "/RPC2"

@kynan kynan Mar 28, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.__handler = p.path or "/RPC2"
self.__handler = p.path

if p.query:
self.__handler += "?" + p.query

@kynan kynan Mar 28, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if not self.__handler:
self.__handler = "/RPC2"

if transport is None:
if p.scheme == "https":
Expand Down