Repository navigation
bpo-43330: pass uri query parameters along xmlrpc requests - #24683
Closed
Julien00859 wants to merge 1 commit into
Closed
Julien00859 wants to merge 1 commit into
Julien00859 wants to merge 1 commit into
Conversation
When using the `xmlrpc.client.ProxyServer` object to access via rpc a remote server, the params and query segments of the uri were discarded. The xml-rpc specification does not say anything about those two segments and py2's xmlrpclib was sending them already.
Author
|
The "bug" was introduced when the original author switched from py2 urllib to py3 urllib. He forgot to include params and query in the resulting http request. |
|
This PR is stale because it has been open for 30 days with no activity. |
Author
|
Fixed by #25057 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the
xmlrpc.client.ProxyServerobject to access via rpc aremote server, the params and query segments of the uri were discarded.
The xml-rpc specification does not say anything about those two
segments and py2's xmlrpclib was sending them already.
https://bugs.python.org/issue43330