Skip to content

bpo-40170: Convert PyDescr_IsData macro to C function #24535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 5 commits into from
Feb 16, 2021
Merged

bpo-40170: Convert PyDescr_IsData macro to C function #24535

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b5a439
bpo-40170: Convert PyDescr_IsData macro to a function
Feb 15, 2021
dbcef69
Add NEWS
Feb 15, 2021
c64feb5
Address review: Improve NEWS entry
Feb 15, 2021
7d71a1a
Add PyDescr_IsData to the limited API
Feb 15, 2021
00b89fd
Revert "Add PyDescr_IsData to the limited API"
Feb 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add PyDescr_IsData to the limited API
  • Loading branch information
Erlend E. Aasland
Erlend E. Aasland committed Feb 15, 2021
commit 7d71a1a5c26a8289d70e599b4dd2c6763340290a
3 changes: 3 additions & 0 deletions Include/descrobject.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ PyAPI_FUNC(PyObject *) PyDescr_NewGetSet(PyTypeObject *,
#ifndef Py_LIMITED_API
PyAPI_FUNC(PyObject *) PyDescr_NewWrapper(PyTypeObject *,
struct wrapperbase *, void *);
#endif

#if !defined(Py_LIMITED_API) || Py_LIMITED_API+0 >= 0x030A0000
PyAPI_FUNC(int) PyDescr_IsData(PyObject *);
Comment thread
erlend-aasland marked this conversation as resolved.
#endif

Expand Down
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Core and Builtins/2021-02-15-13-41-14.bpo-40170.r2FAtl.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Convert :c:func:`PyDescr_IsData` macro to a function to hide implementation
details: The macro accessed :c:member:`PyTypeObject.tp_descr_set` directly.
Patch by Erlend E. Aasland.
The function is now a part of the limited C API. Patch by Erlend E. Aasland.