Skip to content

bpo-28518: Start a transaction implicitly before a DML statement #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
berkerpeksag merged 3 commits into from
Feb 26, 2017
Merged

bpo-28518: Start a transaction implicitly before a DML statement #245

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbeabf4
bpo-28518: Start a transaction implicitly before a DML statement
berkerpeksag Feb 22, 2017
3018942
Use is_dml instead of sqlite3_stmt_readonly()
berkerpeksag Feb 23, 2017
d5917ce
Merge branch 'master' into 2858-sqlite3-begin
berkerpeksag Feb 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use is_dml instead of sqlite3_stmt_readonly()
  • Loading branch information
@berkerpeksag
berkerpeksag committed Feb 23, 2017
commit 3018942f1c8c825b4258ec21ad419ea95e399779
2 changes: 1 addition & 1 deletion Modules/_sqlite/cursor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,7 @@ PyObject* _pysqlite_query_execute(pysqlite_Cursor* self, int multiple, PyObject*
}
}

if (!sqlite3_stmt_readonly(self->statement->st)) {
if (self->statement->is_dml) {
self->rowcount += (long)sqlite3_changes(self->connection->db);
} else {
self->rowcount= -1L;
Expand Down