Skip to content

[WIP] bpo-42294: Add PyTuple_GetItemRef() function #23207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vstinner wants to merge 2 commits into from
Closed

[WIP] bpo-42294: Add PyTuple_GetItemRef() function #23207

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7525a38
bpo-42294: Add PyTuple_GetItemRef() function
vstinner Nov 9, 2020
89aabcb
Fix typo
vstinner Nov 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix typo
  • Loading branch information
@vstinner
vstinner committed Nov 9, 2020
commit 89aabcbf8ba45bd66f84b1b5e946000a33aa0a1e
2 changes: 1 addition & 1 deletion Modules/_datetimemodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3276,7 +3276,7 @@ iso_calendar_date_week(PyDateTime_IsoCalendarDate *self, void *unused)
static PyObject *
iso_calendar_date_weekday(PyDateTime_IsoCalendarDate *self, void *unused)
{
return PyTuple_GetItem((PyObject *)self, 2);
return PyTuple_GetItemRef((PyObject *)self, 2);
}

static PyGetSetDef iso_calendar_date_getset[] = {
Expand Down
3 changes: 1 addition & 2 deletions Objects/tupleobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,7 @@ PyTuple_GetItemRef(PyObject *op, Py_ssize_t i)
{
PyObject *item = PyTuple_GetItem(op, i);
// On a newly created tuple, an item can still be NULL
Py_XINCREF(item);
return item;
return Py_XNewRef(item);
}

int
Expand Down