Skip to content

bpo-41712 Vulnerable Regex Changed #23191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pixmew wants to merge 10 commits into from
Closed

bpo-41712 Vulnerable Regex Changed #23191

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
eac3276
Unnessery regex conditions are removed
Pixmew Nov 5, 2020
f3f4725
Vulnerable regex conditions are removed
Pixmew Nov 5, 2020
8e502ad
📜🤖 Added by blurb_it.
blurb-it[bot] Nov 6, 2020
9a4c1a5
edited
Pixmew Nov 6, 2020
fddf4f1
edited for avoiding docs failure
Pixmew Nov 6, 2020
d4004c6
📜🤖 Added by blurb_it.
blurb-it[bot] Nov 6, 2020
40b6373
linux test failure reason
Pixmew Nov 6, 2020
52f7af2
Update Misc/NEWS.d/next/Tools-Demos/2020-11-06-09-12-13.bpo-41712.WOE…
Pixmew Nov 7, 2020
eb1500c
Update Tools/msi/purge.py
Pixmew Nov 7, 2020
aab27c2
Updated news
Pixmew Nov 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Vulnerable regex conditions are removed 
bpo-41712: Removal of Vulnerable regex conditions  
Using suggestion  ""For example, you can modify the sub-pattern \w+\d+ to ([A-Za-z_]*\d)+""  and converted to ([A-za-z_]+\d+)
which should Fix the issue of vulnerable regex.
Test Result : Working as intended

Sorry if this not much this is my first pr to big org.
  • Loading branch information
@Pixmew
Pixmew authored Nov 5, 2020
commit f3f47257266ef44832819ec24eb629434d8b7dd3
2 changes: 1 addition & 1 deletion Tools/msi/purge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

from urllib.request import *

VERSION_RE = re.compile(r'(\d+\.\d+\.\d+)(\w+)$')
VERSION_RE = re.compile(r'(\d+\.\d+\.\d+)([A-Za-z_]+\d+)$')

try:
m = VERSION_RE.match(sys.argv[1])
Expand Down