Skip to content

gh-78143: IDLE - replace config dlg scale with ttk spinbox #22954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terryjreedy merged 16 commits into from
Jun 10, 2021
Merged

gh-78143: IDLE - replace config dlg scale with ttk spinbox #22954

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
cd1c79e
bpo-33962: replace idle config dlg scale with ttk spinbox
roseman Oct 25, 2020
6481f11
Remove trailing whitespace and extra blank line
terryjreedy Oct 25, 2020
d20668c
Merge remote-tracking branch 'upstream/master' into idle-config-spinb…
roseman Oct 25, 2020
bf5ace1
bpo-33962: replace idle config dlg scale with ttk spinbox
roseman Oct 25, 2020
5ddb0ec
Remove trailing whitespace and extra blank line
terryjreedy Oct 25, 2020
9573e8e
switched spinbox to reaonly (entry part not editable), cleared select…
roseman Oct 25, 2020
685202f
Merge branch 'idle-config-spinbox-33962' of https://github.com/rosema…
roseman Oct 25, 2020
e3a1891
Merge branch 'master' into idle-config-spinbox-33962
terryjreedy Jan 25, 2021
60ea384
Merge remote-tracking branch 'upstream/main' into pr_22954
terryjreedy Jun 8, 2021
daf6517
Merge remote-tracking branch 'upstream/main' into pr_22954
terryjreedy Jun 10, 2021
a6fc39d
General changes
terryjreedy Jun 10, 2021
f212861
Works with combobox
terryjreedy Jun 10, 2021
90c778d
Working readonly spinbox
terryjreedy Jun 10, 2021
bb3c32f
Writable spinbox working
terryjreedy Jun 10, 2021
4919b54
blurb
terryjreedy Jun 10, 2021
b842114
Add digits-only validations.
terryjreedy Jun 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
General changes
  • Loading branch information
@terryjreedy
terryjreedy committed Jun 10, 2021
commit a6fc39dff98d681b6ae5baf94af85d135016aa21
48 changes: 23 additions & 25 deletions Lib/idlelib/configdialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,9 @@ def create_widgets(self):
highpage: HighPage
fontpage: FontPage
keyspage: KeysPage
genpage: GenPage
extpage: self.create_page_extensions
winpage: WinPage
shedpage: ShedPage
extpage: ExtPage

Methods:
create_action_buttons
Expand Down Expand Up @@ -300,12 +301,12 @@ class FontPage(Frame):
def __init__(self, master, highpage):
super().__init__(master)
self.highlight_sample = highpage.highlight_sample
self.create_page_font_tab()
self.create_page_font()
self.load_font_cfg()
self.load_tab_cfg()

def create_page_font_tab(self):
"""Return frame of widgets for Font/Tabs tab.
def create_page_font(self):
"""Return frame of widgets for Font tab.

Fonts: Enable users to provisionally change font face, size, or
boldness and to see the consequence of proposed choices. Each
Expand All @@ -329,11 +330,6 @@ def create_page_font_tab(self):
Set_samples applies a new font constructed from the font vars to
font_sample and to highlight_sample on the highlight page.

Tabs: Enable users to change spaces entered for indent tabs.
Changing indent_chooser value with the mouse sets Var space_num,
which invokes the default callback to add an entry to
changes. Load_tab_cfg initializes space_num to default.

Widgets for FontPage(Frame): (*) widgets bound to self
frame_font: LabelFrame
frame_font_name: Frame
Expand Down Expand Up @@ -522,7 +518,7 @@ def __init__(self, master, extpage):
self.load_theme_cfg()

def create_page_highlight(self):
"""Return frame of widgets for Highlighting tab.
"""Return frame of widgets for Highlights tab.

Enable users to provisionally change foreground and background
colors applied to textual tags. Color mappings are stored in
Expand Down Expand Up @@ -1624,40 +1620,42 @@ def create_page_windows(self):
"""Return frame of widgets for Windows tab.

Enable users to provisionally change general window options.
Function load_windows_cfg initializes tk variables idleConf.
Function load_windows_cfg initializes tk variable idleConf.
Radiobuttons startup_shell_on and startup_editor_on set var
startup_edit. Entry boxes win_width_int and win_height_int set var
win_width and win_height. Setting var_name invokes the default
callback that adds option to changes.

Widgets for WinPage(Frame): (*) widgets bound to self
Widgets for WinPage(Frame): > vars, bound to self
frame_window: LabelFrame
frame_run: Frame
startup_title: Label
(*)startup_editor_on: Radiobutton - startup_edit
(*)startup_shell_on: Radiobutton - startup_edit
startup_editor_on: Radiobutton > startup_edit
startup_shell_on: Radiobutton > startup_edit
frame_win_size: Frame
win_size_title: Label
win_width_title: Label
(*)win_width_int: Entry - win_width
win_width_int: Entry > win_width
win_height_title: Label
(*)win_height_int: Entry - win_height
frame_cursor_blink: Frame
cursor_blink_title: Label
(*)cursor_blink_bool: Checkbutton - cursor_blink
win_height_int: Entry > win_height
frame_cursor: Frame
indent_title: Label
indent_chooser: Spinbox (Combobox < 8.5.9) > indent_spaces
blink_on: Checkbutton > cursor_blink

frame_autocomplete: Frame
auto_wait_title: Label
(*)auto_wait_int: Entry - autocomplete_wait
auto_wait_int: Entry > autocomplete_wait
frame_paren1: Frame
paren_style_title: Label
(*)paren_style_type: OptionMenu - paren_style
paren_style_type: OptionMenu > paren_style
frame_paren2: Frame
paren_time_title: Label
(*)paren_flash_time: Entry - flash_delay
(*)bell_on: Checkbutton - paren_bell
paren_flash_time: Entry > flash_delay
bell_on: Checkbutton > paren_bell
frame_format: Frame
format_width_title: Label
(*)format_width_int: Entry - format_width
format_width_int: Entry > format_width
"""
# Integer values need StringVar because int('') raises.
self.startup_edit = tracers.add(
Expand Down