Skip to content

gh-62142: IDLE - rework debugger UI #22947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roseman wants to merge 12 commits into from
Closed

gh-62142: IDLE - rework debugger UI #22947

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ab7d734
bpo-17942: reworking of debugger UI
roseman Oct 24, 2020
3cabc0a
scrolledlist no longer needed
roseman Oct 24, 2020
a8b8da4
adjust fonts to use standard named fonts
roseman Oct 25, 2020
7787255
Apply suggestions from code review
roseman Nov 2, 2020
37399ed
apply suggestions from code review
roseman Nov 2, 2020
041d552
apply suggestions from code review
roseman Nov 2, 2020
448527e
clean up based on review comments - re, exception
roseman Nov 4, 2020
a057032
explicit tkinter imports as per review comments
roseman Nov 4, 2020
4304969
status line always goes below toolbar buttons, regardless of window w…
roseman Nov 15, 2020
812768f
Apply suggestions from code review (comments)
roseman Nov 15, 2020
72740a3
missing import
roseman Nov 15, 2020
f9f9331
tweak comments as per review suggestions
roseman Nov 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adjust fonts to use standard named fonts 
- button captions now use TkIconFont (a bit bigger than before)
- status line now uses default font, plus derives italic variation for errors
  • Loading branch information
@roseman
roseman committed Oct 25, 2020
commit a8b8da45585764f16a8667252324497ac81e7737
12 changes: 7 additions & 5 deletions Lib/idlelib/debugger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,6 @@ def make_gui(self):
self.pane.add(left, weight=1)
controls = ttk.Frame(left)
col = 0
Comment thread
roseman marked this conversation as resolved.
Outdated
f = ('helvetica', 9)
self.buttondata = {}
self.buttons = ['go', 'step', 'over', 'out', 'stop', 'prefs']
Comment thread
roseman marked this conversation as resolved.
self.button_names = {'go':'Go', 'step':'Step', 'over':'Over',
Comment thread
roseman marked this conversation as resolved.
Outdated
Comment thread
roseman marked this conversation as resolved.
Outdated
Expand All @@ -188,12 +187,15 @@ def make_gui(self):
normal = self.getimage('debug_'+key+'.gif')
disabled = self.getimage('debug_'+key+'_disabled.gif')
b = ttk.Label(controls, image=normal, text=self.button_names[key],
compound='top', font=f)
compound='top', font='TkIconFont')
b.grid(column=col, row=0, padx=[0,5])
self.buttondata[key] = (b, normal, disabled)
col += 1
Comment thread
roseman marked this conversation as resolved.
Outdated
self.enable_buttons(['prefs'])
self.status = ttk.Label(controls, text=' ', font=('helvetica', 13))
self.status_normal_font = Font(root=self.root, name='TkDefaultFont', exists=True)
self.status_error_font = self.status_normal_font.copy()
self.status_error_font['slant'] = 'italic'
self.status = ttk.Label(controls, text=' ', font=self.status_normal_font)
self.status.grid(column=6, row=0, sticky='nw', padx=[25,0])
controls.grid(column=0, row=0, sticky='new', pady=[0,6])
controls.grid_columnconfigure(7, weight=1)
Expand Down Expand Up @@ -292,8 +294,8 @@ def show_source(self, item):
def show_status(self, msg, error=False):
self.status['text'] = msg
self.status['foreground'] = '#ff0000' if error else '#006600'
self.status['font'] = ('helvetica', 13, 'italic') if error \
else ('helvetica', 13)
self.status['font'] = self.status_error_font if error \
else self.status_normal_font

def clear_stack(self):
self.stack.delete(*self.stack.get_children(''))
Expand Down