Skip to content

bpo-41513: Add docs and tests for hypot() #22238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhettinger merged 12 commits into from
Sep 14, 2020
Merged

bpo-41513: Add docs and tests for hypot() #22238

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0f7a2ff
Note performance aspects of using multiple accumulators
rhettinger Sep 6, 2020
7a29756
Add accuracy notes
rhettinger Sep 6, 2020
971ae45
Show where each footnote applies
rhettinger Sep 6, 2020
080c68a
Better wording for the incremental loop costs
rhettinger Sep 6, 2020
b6ecce6
Improve wording for the accuracy paragraph
rhettinger Sep 6, 2020
f32a43d
Add test cases
rhettinger Sep 14, 2020
5c3413c
Show subtest parameters in hex.
rhettinger Sep 14, 2020
e9a4700
Improve comment
rhettinger Sep 14, 2020
f79dc78
Remove doubt by computing reference values directly
rhettinger Sep 14, 2020
8b20c2d
Add documentation
rhettinger Sep 14, 2020
2862f26
Fix order of references in notes
rhettinger Sep 14, 2020
47bc660
Merge branch 'master' into hypot_notes
rhettinger Sep 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Better wording for the incremental loop costs
  • Loading branch information
@rhettinger
rhettinger committed Sep 6, 2020
commit 080c68a3748e701f65244f984a61e6eecbe0b2f7
5 changes: 3 additions & 2 deletions Modules/mathmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2458,8 +2458,9 @@ Since lo**2 is less than 1/2 ulp(csum), we have csum+lo*lo == csum.
To minimize loss of information during the accumulation of fractional
values, each term has a separate accumulator. This also breaks up
sequential dependencies in the inner loop so the CPU can maximize
floating point throughput. [5] On a 2.6 GHz Haswell, moving from
hypot(x,y) to hypot(x,y,z) costs only 5ns.
floating point throughput. [5] On a 2.6 GHz Haswell, adding one
dimension has an incremental cost of only 5ns -- for example when
moving from hypot(x,y) to hypot(x,y,z).

The square root differential correction is needed because a
correctly rounded square root of a correctly rounded sum of
Expand Down