Skip to content

Fix compiler warnings in init_dump_ascii_wstr() - #22143

Closed
vstinner wants to merge 1 commit into
python:masterfrom
vstinner:init_dump_ascii_wstr
Closed

vstinner wants to merge 1 commit into
python:masterfrom
vstinner:init_dump_ascii_wstr

Conversation

@vstinner

@vstinner vstinner commented Sep 7, 2020

Copy link
Copy Markdown
Member

Fix GCC 9.3 (using -O3) warnings on x86:

initconfig.c: In function ‘init_dump_ascii_wstr’:
initconfig.c:2679:34: warning: format ‘%lc’ expects argument of type
‘wint_t’, but argument 2 has type ‘wchar_t’ {aka ‘long int’}
2679 | PySys_WriteStderr("%lc", ch);
initconfig.c:2682:38: warning: format ‘%x’ expects argument of type
‘unsigned int’, but argument 2 has type ‘wchar_t’ {aka ‘long int’}
2682 | PySys_WriteStderr("\x%02x", ch);
initconfig.c:2686:38: warning: format ‘%x’ expects argument of type
‘unsigned int’, but argument 2 has type ‘wchar_t’ {aka ‘long int’}
2686 | PySys_WriteStderr("\U%08x", ch);
initconfig.c:2690:38: warning: format ‘%x’ expects argument of type
‘unsigned int’, but argument 2 has type ‘wchar_t’ {aka ‘long int’}
2690 | PySys_WriteStderr("\u%04x", ch);

Fix GCC 9.3 (using -O3) warnings on x86:

initconfig.c: In function ‘init_dump_ascii_wstr’:
initconfig.c:2679:34: warning: format ‘%lc’ expects argument of type
‘wint_t’, but argument 2 has type ‘wchar_t’ {aka ‘long int’}
 2679 |             PySys_WriteStderr("%lc", ch);
initconfig.c:2682:38: warning: format ‘%x’ expects argument of type
‘unsigned int’, but argument 2 has type ‘wchar_t’ {aka ‘long int’}
 2682 |             PySys_WriteStderr("\\x%02x", ch);
initconfig.c:2686:38: warning: format ‘%x’ expects argument of type
‘unsigned int’, but argument 2 has type ‘wchar_t’ {aka ‘long int’}
 2686 |             PySys_WriteStderr("\\U%08x", ch);
initconfig.c:2690:38: warning: format ‘%x’ expects argument of type
‘unsigned int’, but argument 2 has type ‘wchar_t’ {aka ‘long int’}
 2690 |             PySys_WriteStderr("\\u%04x", ch);
@vstinner

vstinner commented Sep 8, 2020

Copy link
Copy Markdown
Member Author

" Travis CI - Pull Request Queued — Build Created (Required) Details"

"62047.3 Documentation tests" job is blocked in the "queued" state.

This morning, I clicked on (Restart build) at https://travis-ci.com/github/python/cpython/builds/183232524

Problem: rather than replacing the old Travis CI job, it added a new second Travis CI job. The new one passed, the previous one never completed...

Let me try the hard way: close/reopen the PR, to recreate all CI jobs :-(

@vstinner

vstinner commented Sep 8, 2020

Copy link
Copy Markdown
Member Author

The Travis CI is a known bug and it needs a GitHub admin to remove an old webhook: python/core-workflow#374

@vstinner

vstinner commented Sep 8, 2020

Copy link
Copy Markdown
Member Author

I recreated the PR since this one is blocked by a sick Travis CI job -> PR #22150.

@vstinner vstinner closed this Sep 8, 2020
@vstinner
vstinner deleted the init_dump_ascii_wstr branch September 8, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants