Skip to content

bpo-41324 Add a minimal decimal capsule API #21519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skrah merged 21 commits into from
Aug 10, 2020
Merged

bpo-41324 Add a minimal decimal capsule API #21519

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
8754016
Add a minimal decimal capsule API.
skrah Jul 17, 2020
72f95d8
Add PyDec_GetConst() and PyDec_GetDigits().
skrah Jul 18, 2020
83366fb
Group the functions into simple and advanced API.
skrah Jul 18, 2020
3636589
Add PyDec_IsSpecial(), PyDec_IsNaN() and PyDec_IsInfinite().
skrah Jul 18, 2020
3208099
Mention ABI stability of mpd_t.
skrah Jul 18, 2020
fa6e201
Remove test_decimal_api_get_digits() duplicate.
skrah Jul 18, 2020
3a0db41
Move the TypeError into PyDec_AsUint128Triple() for a consistent API.
skrah Jul 18, 2020
2fcc6ff
Fix error message.
skrah Jul 18, 2020
9ac33c3
Add documentation.
skrah Jul 18, 2020
d8e23da
Appease the Sphinx linter.
skrah Jul 18, 2020
948a62e
Rename decimal.h to pydecimal.h.
skrah Jul 20, 2020
cff9084
Move decimal test functions out of the datetime section.
skrah Jul 20, 2020
fff8826
Fix typo.
skrah Jul 20, 2020
193bc41
Merge branch 'master' of https://github.com/python/cpython into minim…
skrah Jul 20, 2020
79c46d9
Make maxcontext a static const.
skrah Jul 20, 2020
9bd11b6
Merge branch 'master' of https://github.com/python/cpython into minim…
skrah Jul 22, 2020
81992c5
Remove libmpdec_triple.h.
skrah Jul 22, 2020
b62baf6
Merge branch 'master' of https://github.com/python/cpython into minim…
skrah Aug 8, 2020
dd860dd
Merge branch 'master' of https://github.com/python/cpython into minim…
skrah Aug 10, 2020
3bf0e2d
Fix array type (not that it matters with all that capsule casting).
skrah Aug 10, 2020
ec73b29
Add blurb.
skrah Aug 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove test_decimal_api_get_digits() duplicate.
  • Loading branch information
Stefan Krah committed Jul 18, 2020
commit fa6e201984c0692c87654dc630b35455d3b5f49b
52 changes: 14 additions & 38 deletions Lib/test/test_decimal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4755,29 +4755,28 @@ def test_constants(self):
self.assertEqual(C.DecTraps,
C.DecErrors|C.DecOverflow|C.DecUnderflow)

def test_decimal_api_get_digits(self):
def test_decimal_api_predicates(self):
# Capsule API

d = C.Decimal("0")
self.assertEqual(decimal_get_digits(d), 1)

d = C.Decimal("1234567890")
self.assertEqual(decimal_get_digits(d), 10)

d = C.Decimal("inf")
self.assertEqual(decimal_get_digits(d), 0)
self.assertFalse(decimal_is_special(d))
self.assertFalse(decimal_is_nan(d))
self.assertFalse(decimal_is_infinite(d))

d = C.Decimal("NaN")
self.assertEqual(decimal_get_digits(d), 0)
self.assertTrue(decimal_is_special(d))
self.assertTrue(decimal_is_nan(d))
self.assertFalse(decimal_is_infinite(d))

d = C.Decimal("sNaN")
self.assertEqual(decimal_get_digits(d), 0)

d = C.Decimal("NaN1234567890")
self.assertEqual(decimal_get_digits(d), 10)
self.assertTrue(decimal_is_special(d))
self.assertTrue(decimal_is_nan(d))
self.assertFalse(decimal_is_infinite(d))

d = C.Decimal("sNaN1234567890")
self.assertEqual(decimal_get_digits(d), 10)
d = C.Decimal("inf")
self.assertTrue(decimal_is_special(d))
self.assertFalse(decimal_is_nan(d))
self.assertTrue(decimal_is_infinite(d))

def test_decimal_api_get_digits(self):
# Capsule API
Expand All @@ -4803,29 +4802,6 @@ def test_decimal_api_get_digits(self):
d = C.Decimal("sNaN1234567890")
self.assertEqual(decimal_get_digits(d), 10)

def test_decimal_api_predicates(self):
# Capsule API

d = C.Decimal("0")
self.assertFalse(decimal_is_special(d))
self.assertFalse(decimal_is_nan(d))
self.assertFalse(decimal_is_infinite(d))

d = C.Decimal("NaN")
self.assertTrue(decimal_is_special(d))
self.assertTrue(decimal_is_nan(d))
self.assertFalse(decimal_is_infinite(d))

d = C.Decimal("sNaN")
self.assertTrue(decimal_is_special(d))
self.assertTrue(decimal_is_nan(d))
self.assertFalse(decimal_is_infinite(d))

d = C.Decimal("inf")
self.assertTrue(decimal_is_special(d))
self.assertFalse(decimal_is_nan(d))
self.assertTrue(decimal_is_infinite(d))

def test_decimal_api_triple(self):
# Capsule API

Expand Down