Skip to content

bpo-30660: Replaced PNG files with their lossless optimized version - #2141

Closed
tiagofilipesilva wants to merge 8 commits into
python:masterfrom
tiagofilipesilva:lossless_png
Closed

tiagofilipesilva wants to merge 8 commits into
python:masterfrom
tiagofilipesilva:lossless_png

Conversation

@tiagofilipesilva

@tiagofilipesilva tiagofilipesilva commented Jun 12, 2017 •

Copy link
Copy Markdown

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@tiagofilipesilva

Copy link
Copy Markdown
Author

Sorry everybody, first time using GitHub.

CLA signed; can't add a "trivial" tag.

@brettcannon brettcannon added docs Documentation in the Doc dir trivial labels Jun 12, 2017
@serhiy-storchaka

Copy link
Copy Markdown
Member

Why these changes are needed? This isn't a trivial issue, it need to be discussed on the bug tracker.

@tiagofilipesilva tiagofilipesilva changed the title Replaced PNG files with their lossless optimized version bpo-30660: Replaced PNG files with their lossless optimized version Jun 13, 2017
@rhettinger

Copy link
Copy Markdown
Contributor

This new PNGs look fine to me. How much space is saved?

@tiagofilipesilva

Copy link
Copy Markdown
Author

Sorry Raymond, I had to deal with some things and simply wasn't around…
If I recall properly, ≈ 5 to 50 % depending on the file.

@methane

methane commented Jun 30, 2018

Copy link
Copy Markdown
Member

I want reproducible compression step.

@methane methane closed this Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review docs Documentation in the Doc dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants