Skip to content

bpo-39791 native hooks for importlib.resources.files #20576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaraco merged 12 commits into from
Jun 8, 2020
Merged

bpo-39791 native hooks for importlib.resources.files #20576

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e42bf42
Provide native .files support on SourceFileLoader.
jaraco May 9, 2020
f8c96fa
Add native importlib.resources.files() support to zipimporter. Remove…
jaraco Jun 1, 2020
6304bee
make regen-all
jaraco Jun 2, 2020
948779a
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 2, 2020
3b59071
Merge branch 'master' into feature/39791-resources-files
jaraco Jun 5, 2020
e4d05ef
Move 'files' into the ResourceReader so it can carry the relevant mod…
jaraco Jun 6, 2020
e40ad3f
Create 'importlib.readers' module and add FileReader to it.
jaraco Jun 6, 2020
5ad02bf
Add zip reader and rely on it for a TraversableResources object on zi…
jaraco Jun 6, 2020
3efe34b
Remove TraversableAdapter, no longer needed.
jaraco Jun 6, 2020
10bed14
Update blurb.
jaraco Jun 6, 2020
c44661b
Replace backslashes with forward slashes.
jaraco Jun 6, 2020
2c5755a
Incorporate changes from importlib_metadata 2.0, finalizing the inter…
jaraco Jun 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Create 'importlib.readers' module and add FileReader to it.
  • Loading branch information
@jaraco
jaraco committed Jun 6, 2020
commit e40ad3f34ec689afc0f3a83af31e9d58298d1fb0
9 changes: 2 additions & 7 deletions Lib/importlib/_bootstrap_external.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -982,15 +982,10 @@ def get_data(self, path):
with _io.FileIO(path, 'r') as file:
return file.read()

# TraversableResources
def files(self):
import pathlib
return pathlib.Path(self.path).parent

@_check_name
def get_resource_reader(self, module):
from importlib.abc import TraversableAdapter
return TraversableAdapter(self)
from importlib.readers import FileReader
return FileReader(self)


class SourceFileLoader(FileLoader, SourceLoader):
Expand Down
10 changes: 10 additions & 0 deletions Lib/importlib/readers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import pathlib
from .abc import TraversableResources


class FileReader(TraversableResources):
def __init__(self, loader):
self.path = pathlib.Path(loader.path).parent

def files(self):
return self.path
Loading